🐛 agent service followup fixes

[GitHK]

What do these changes do?

This is a followup to #3465

• agent now properly mounts the docker volumes on the machine
• fixes an issue with docker-compose config where the cpu is not accepted.

Bonus: editing non service files will trigger CI jobs

Related issue/s

• improving dynamic-sidecar design osparc-issues#638

How to test

Checklist

[pcrespov]

I understand you intend to replace the cpus: field to enforce single quotes ' right? If so the way you do it has quite some problems: Check your regex against these example https://regex101.com/r/a99Y5z/1

Moreover, if the problem is docker-compose ... please check the version and the specs for it. Typically it is a problem with incompatibilities between the version of docker-compose (i.e. the executable that runs config) and the version of the compose specs file.

I would prefer solving this by aligning versions than patching the docker-compose in the makefile with sed. Notice how messy would it be if we have to do this with other fields. ..

[mrnicegyu11]

See: docker/compose#7771 (comment)

[GitHK]

As pointed out by the post above, it's an issue with docker-compose that is not getting fixed. Since It is currently frozen at version 1.29.2. We have not upgraded to version 2.x.x which I'm not sure that if fixes this issue.

[pcrespov]

I see, so then I propose that you add a comment in this change so that we can follow up when we do the upgrade of docker-compose.
IMO patching the docker-compose this way should only be done in exceptional circumstances (this could be one of them!).

Regarding the regex... It realize now that I do not understand how really sed works because

echo cpus:    "4.3" | sed -E "s/cpus: ([0-9\\.]+)/cpus: '\\1'/"
cpus: '4.3'

echo "cpus:    '4.3'" | sed -E "s/cpus: ([0-9\\.]+)/cpus: '\\1'/"
cpus:    '4.3'

despite the fact that the regex clearly misses spaces \w and the quotes as shown in https://regex101.com/r/a99Y5z/1

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[mrnicegyu11]

Please capture the env-vars noted in #3465 in the docker-compose.yml

[pcrespov]

Please add a comment in this change with info about the issue so that we can follow up when we do the upgrade of docker-compose
thx

[codecov]

Codecov Report

Merging #3513 (541cfed) into master (d0fba0b) will decrease coverage by 0.2%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #3513     +/-   ##
========================================
- Coverage    82.6%   82.4%   -0.3%     
========================================
  Files         852     852             
  Lines       35978   35978             
  Branches      759     759             
========================================
- Hits        29752   29679     -73     
- Misses       6029    6102     +73     
  Partials      197     197             

Flag	Coverage Δ
integrationtests	52.2% <ø> (-10.0%)	⬇️
unittests	80.5% <ø> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...imcore_service_webserver/exporter/export_import.py	34.1% <0.0%> (-63.5%)	⬇️
...vice_webserver/exporter/formatters/formatter_v2.py	31.9% <0.0%> (-58.6%)	⬇️
...vice_webserver/exporter/formatters/formatter_v1.py	27.6% <0.0%> (-55.9%)	⬇️
...ore_service_webserver/exporter/request_handlers.py	41.3% <0.0%> (-54.7%)	⬇️
...c/simcore_service_webserver/users_to_groups_api.py	46.1% <0.0%> (-53.9%)	⬇️
...core_service_webserver/exporter/file_downloader.py	48.0% <0.0%> (-52.0%)	⬇️
...re_service_webserver/exporter/formatters/models.py	55.1% <0.0%> (-42.4%)	⬇️
...rvice_webserver/exporter/formatters/base_models.py	48.9% <0.0%> (-40.9%)	⬇️
...src/simcore_service_webserver/exporter/settings.py	66.6% <0.0%> (-33.4%)	⬇️
...mcore_service_webserver/garbage_collector_utils.py	52.5% <0.0%> (-30.8%)	⬇️
... and 29 more

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.2% Duplication