-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 adds tests for S3TransferError; refactoring flaky CI test; better logging for long running task errors #3525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3525 +/- ##
=========================================
- Coverage 80.5% 68.4% -12.1%
=========================================
Files 852 503 -349
Lines 35991 22028 -13963
Branches 757 133 -624
=========================================
- Hits 28985 15078 -13907
- Misses 6822 6901 +79
+ Partials 184 49 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please add a more descriptive title for the PR
packages/simcore-sdk/tests/unit/test_node_ports_common_file_io_utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair reviewd
packages/simcore-sdk/tests/unit/test_node_ports_common_file_io_utils.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/tests/unit/test_node_ports_common_file_io_utils.py
Outdated
Show resolved
Hide resolved
packages/simcore-sdk/tests/unit/test_node_ports_common_file_io_utils.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
_check_for_aws_http_errors
.tests/fastapi/long_running_tasks/test_long_running_tasks_context_manager.py::test_task_result_times_out
(lesson learned: when dealing with timeouts always use an order of magnitude of difference in checks)Related issue/s
tests/fastapi/long_running_tasks/test_long_running_tasks_context_manager.py::test_task_result_times_out
in list of flaky tests in CI #3421How to test
Checklist