Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 adds tests for S3TransferError; refactoring flaky CI test; better logging for long running task errors #3525

Merged
merged 12 commits into from
Nov 9, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 8, 2022

What do these changes do?

  • Adds tests for _check_for_aws_http_errors.
  • adjusts timeout detection interval in tests/fastapi/long_running_tasks/test_long_running_tasks_context_manager.py::test_task_result_times_out (lesson learned: when dealing with timeouts always use an order of magnitude of difference in checks)
  • enhances logging when long running fastapi tasks finished with error

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #3525 (d874f7d) into master (31ac97f) will decrease coverage by 12.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3525      +/-   ##
=========================================
- Coverage    80.5%   68.4%   -12.1%     
=========================================
  Files         852     503     -349     
  Lines       35991   22028   -13963     
  Branches      757     133     -624     
=========================================
- Hits        28985   15078   -13907     
- Misses       6822    6901      +79     
+ Partials      184      49     -135     
Flag Coverage Δ
integrationtests 66.4% <ø> (-12.9%) ⬇️
unittests 77.3% <ø> (-2.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...e_service_webserver/login/handlers_confirmation.py 27.2% <0.0%> (-69.1%) ⬇️
... and 551 more

@GitHK GitHK changed the title adding tests Adds tests to _check_for_aws_http_errors Nov 8, 2022
@GitHK GitHK changed the title Adds tests to _check_for_aws_http_errors ♻️ Adds tests to _check_for_aws_http_errors Nov 8, 2022
@GitHK GitHK self-assigned this Nov 8, 2022
@GitHK GitHK added this to the Katherine Switzer milestone Nov 8, 2022
@GitHK GitHK changed the title ♻️ Adds tests to _check_for_aws_http_errors ♻️ Various test fixes Nov 8, 2022
@GitHK GitHK changed the title ♻️ Various test fixes 🐛 Various test fixes Nov 8, 2022
@GitHK GitHK marked this pull request as ready for review November 8, 2022 12:52
@GitHK GitHK requested a review from pcrespov as a code owner November 8, 2022 12:52
@GitHK GitHK requested a review from sanderegg November 8, 2022 12:52
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add a more descriptive title for the PR

@GitHK GitHK requested a review from pcrespov November 8, 2022 14:08
@GitHK GitHK changed the title 🐛 Various test fixes 🐛 adds tests for S3TransferError; refactoring flaky CI test; better logging for long running task errors Nov 8, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewd

@GitHK GitHK enabled auto-merge (squash) November 9, 2022 10:22
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 767860c into ITISFoundation:master Nov 9, 2022
@GitHK GitHK deleted the pr-osparc-s3-400-issues branch November 9, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants