馃悰 Force File Picker progress to be between 1 and 99 #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
a:frontend
odeimaiz
requested review from
sanderegg,
GitHK,
mguidon,
mrnicegyu11 and
pcrespov
mrnicegyu11
approved these changes
Nov 14, 2022
Bad enough for making it hotfix candidate... |
pcrespov
approved these changes
Nov 14, 2022
pcrespov
reviewed
Nov 14, 2022
GitHK
approved these changes
Nov 15, 2022
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Buggy scenario: With an overloaded backend, the multipart uploading process was very slow, making the buggy File Picker's progress calculation negative for the very first uploaded parts and, therefore, study's validation faulty. This PR forces the value to be between 1 (started) and 99 (almost finished).
Related issue/s
How to test
Checklist