Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Rerevise docker networks dk (bis) (⚠️ devops) #3564

Conversation

sanderegg
Copy link
Member

What do these changes do?

#3543
Bonus: ensure CI triggers on all tests if docker-compose files are changed.

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the Athena milestone Nov 14, 2022
@sanderegg sanderegg self-assigned this Nov 14, 2022
@sanderegg sanderegg changed the title ♻️ Rrevise docker networks dk (bis) (⚠️ devops) ♻️ Rerevise docker networks dk (bis) (⚠️ devops) Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #3564 (53a7402) into master (850f535) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3564     +/-   ##
========================================
- Coverage    83.5%   83.4%   -0.1%     
========================================
  Files         853     853             
  Lines       36022   36022             
  Branches      759     759             
========================================
- Hits        30091   30077     -14     
- Misses       5734    5748     +14     
  Partials      197     197             
Flag Coverage Δ
integrationtests 67.2% <ø> (-0.1%) ⬇️
unittests 80.5% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore_service_director_v2/utils/dask_client_utils.py 80.8% <0.0%> (-6.1%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 91.1% <0.0%> (-1.9%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 68.6% <0.0%> (-1.9%) ⬇️
...ore_service_director_v2/api/routes/computations.py 93.3% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 67.5% <0.0%> (+0.2%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sanderegg sanderegg merged commit dcedd74 into ITISFoundation:master Nov 15, 2022
@sanderegg sanderegg deleted the maintenance/revise_docker_networks_dk branch November 15, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants