-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Rerevise docker networks dk (bis) (⚠️ devops) #3564
Merged
sanderegg
merged 4 commits into
ITISFoundation:master
from
sanderegg:maintenance/revise_docker_networks_dk
Nov 15, 2022
Merged
♻️ Rerevise docker networks dk (bis) (⚠️ devops) #3564
sanderegg
merged 4 commits into
ITISFoundation:master
from
sanderegg:maintenance/revise_docker_networks_dk
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
Surfict,
mrnicegyu11 and
pcrespov
as code owners
November 14, 2022 21:25
sanderegg
changed the title
♻️ Rrevise docker networks dk (bis) (⚠️ devops)
♻️ Rerevise docker networks dk (bis) (⚠️ devops)
Nov 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #3564 +/- ##
========================================
- Coverage 83.5% 83.4% -0.1%
========================================
Files 853 853
Lines 36022 36022
Branches 759 759
========================================
- Hits 30091 30077 -14
- Misses 5734 5748 +14
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mrnicegyu11
approved these changes
Nov 15, 2022
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
#3543
Bonus: ensure CI triggers on all tests if docker-compose files are changed.
Related issue/s
How to test
Checklist