Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 agent running in production now has access to rclone #3571

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 16, 2022

What do these changes do?

rclone was installed in the wrong docker image layer and was not available when running in production mode.

Related issue/s

How to test

Checklist

@GitHK GitHK self-assigned this Nov 16, 2022
@GitHK GitHK added this to the Athena milestone Nov 16, 2022
@GitHK GitHK marked this pull request as ready for review November 16, 2022 09:21
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #3571 (83a3a26) into master (45ca6ad) will increase coverage by 11.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3571      +/-   ##
=========================================
+ Coverage    83.4%   95.0%   +11.5%     
=========================================
  Files         853      13     -840     
  Lines       36023     303   -35720     
  Branches      759       0     -759     
=========================================
- Hits        30073     288   -29785     
+ Misses       5753      15    -5738     
+ Partials      197       0     -197     
Flag Coverage 螖
integrationtests ?
unittests 95.0% <酶> (+14.5%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ls-library/src/models_library/rabbitmq_messages.py
...s/service-library/src/servicelib/rabbitmq_utils.py
...es/settings-library/src/settings_library/rabbit.py
...rector_v2/modules/comp_scheduler/dask_scheduler.py
...vice_director_v2/modules/comp_scheduler/factory.py
...es/dynamic_sidecar/docker_service_specs/sidecar.py
...e_service_director_v2/modules/projects_networks.py
...rc/simcore_service_director_v2/modules/rabbitmq.py
...mcore_service_dynamic_sidecar/api/_dependencies.py
...namic_sidecar/api/containers_long_running_tasks.py
... and 830 more

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK enabled auto-merge (squash) November 16, 2022 09:35
@GitHK GitHK merged commit f8bce03 into ITISFoundation:master Nov 16, 2022
@GitHK GitHK deleted the pr-osparc-agent-rclone branch November 16, 2022 10:17
pcrespov pushed a commit that referenced this pull request Nov 23, 2022
Co-authored-by: Andrei Neagu <neagu@itis.swiss>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants