Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 agent rclone configuration fixes #3580

Merged
merged 7 commits into from
Nov 17, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 17, 2022

What do these changes do?

Agent clone configuration appears not to be correct in master, which runs with a CEPH backend.

  • 鈾伙笍 rlcone output afet sync command is more helpful (states what files it synced)
  • 馃悰 Fiexed issues with MINIO and CEPH in S3Provider enum that caused warnings in the logs. (unsure if these also blocked transfers)

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Nov 17, 2022
@GitHK GitHK added this to the Athena milestone Nov 17, 2022
@GitHK GitHK changed the title Pr osparc rclone fixes 馃悰 agent rclone configuration fixes Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #3580 (28d3096) into master (b3b01c5) will increase coverage by 5.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3580     +/-   ##
========================================
+ Coverage    78.6%   84.3%   +5.7%     
========================================
  Files         729     651     -78     
  Lines       32105   28564   -3541     
  Branches      489     178    -311     
========================================
- Hits        25254   24106   -1148     
+ Misses       6738    4399   -2339     
+ Partials      113      59     -54     
Flag Coverage 螖
integrationtests 67.2% <酶> (+3.1%) 猬嗭笍
unittests 80.8% <100.0%> (+4.4%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...s/settings-library/src/settings_library/catalog.py 100.0% <100.0%> (酶)
...ings-library/src/settings_library/utils_r_clone.py 100.0% <100.0%> (酶)
...mcore_service_agent/modules/volumes_cleanup/_s3.py 97.6% <100.0%> (+0.4%) 猬嗭笍
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 94.0% <0.0%> (-3.0%) 猬囷笍
...dynamic_sidecar/modules/directory_watcher/_core.py 96.6% <0.0%> (-0.7%) 猬囷笍
...ce_integration/pytest_plugin/docker_integration.py
...ages/models-library/src/models_library/__init__.py
...e/src/simcore_postgres_database/models/products.py
.../src/simcore_postgres_database/models/comp_runs.py
...rc/models_library/utils/pydantic_models_factory.py
... and 258 more

@GitHK GitHK marked this pull request as ready for review November 17, 2022 10:00
@GitHK GitHK requested a review from Surfict November 17, 2022 10:06
@GitHK GitHK enabled auto-merge (squash) November 17, 2022 10:06
@GitHK GitHK requested a review from pcrespov November 17, 2022 11:32
@GitHK GitHK enabled auto-merge (squash) November 17, 2022 11:32
@GitHK GitHK disabled auto-merge November 17, 2022 11:32
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK enabled auto-merge (squash) November 17, 2022 13:54
@GitHK GitHK disabled auto-merge November 17, 2022 14:29
@GitHK GitHK enabled auto-merge (squash) November 17, 2022 14:30
@GitHK GitHK merged commit 59e59b5 into ITISFoundation:master Nov 17, 2022
@GitHK GitHK deleted the pr-osparc-rclone-fixes branch November 17, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants