e2e: publications #3650
Merged
e2e: publications #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into e2e/publications
odeimaiz
requested review from
pcrespov,
elisabettai,
GitHK,
mguidon,
mrnicegyu11,
sanderegg and
newton1985
… into e2e/publications
pcrespov
approved these changes
Dec 7, 2022
newton1985
approved these changes
Dec 8, 2022
sanderegg
approved these changes
Dec 8, 2022
elisabettai
approved these changes
Dec 8, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It turns out that a Voila e2e test was already in place.
This PR improves that test, so that it can also be used with Maxwell's publication. It also moves some tests around (s4l) and removes the Mattward test, which was tested in both e2e and p2e (we only keep the p2e). It also improves the ti-plan test.
In summary, we end up with this folder/test structure:
Nature publication, Participant 2 (there are many cuts to not make it extra long):
Related issue/s
How to test
Checklist