🐛fixed test blocking CI in director-v2 unittests

[GitHK]

What do these changes do?

How this test passed the CI is a complete mystery to me! @sanderegg or @pcrespov any ideas?

Related issue/s

Not sure why the CI passed on this test.

How to test

Checklist

[mrnicegyu11]

disable dat rabbit!

thx

[sanderegg]

Just depend on which test ran before... Then a rabbit was up eating carrots

[pcrespov]

@GitHK @sanderegg .

As I mentioned before in mattermost: I think the problem is that the unit-tests in director-v2 are using dynamic-sidecar services as part of the setup.

With the new CI rules, any change in the dynamic-sidecar will not trigger director-v2 unit-tests .
The fact that the problem is in rabbit might be a second order effect. E.g. dynamic-sidecar has changed such that rabbit is used differently and it has to be dsiabled. (this is just speculation)

My advice: let's move all unit-tests using dynamic-sidecar into integration folder or a separate one that is active when changes in the dynamic-sidecar happens

[codecov]

Codecov Report

Merging #3680 (acfae20) into master (4c79785) will decrease coverage by 14.6%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3680      +/-   ##
=========================================
- Coverage    82.3%   67.7%   -14.7%     
=========================================
  Files         883     360     -523     
  Lines       37382   18381   -19001     
  Branches      785     135     -650     
=========================================
- Hits        30798   12446   -18352     
+ Misses       6376    5886     -490     
+ Partials      208      49     -159     

Flag	Coverage Δ
integrationtests	67.7% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...service_webserver/projects/_project_models_rest.py	0.0% <0.0%> (-100.0%)	⬇️
...es/web/server/src/simcore_service_webserver/log.py	0.0% <0.0%> (-94.8%)	⬇️
...erver/src/simcore_service_webserver/rest_models.py	0.0% <0.0%> (-92.7%)	⬇️
...simcore_service_webserver/director/director_api.py	0.0% <0.0%> (-76.0%)	⬇️
...rc/simcore_service_webserver/version_control_db.py	24.5% <0.0%> (-68.7%)	⬇️
...ce_webserver/studies_dispatcher/_studies_access.py	22.2% <0.0%> (-64.9%)	⬇️
...src/simcore_service_webserver/activity/handlers.py	29.3% <0.0%> (-63.8%)	⬇️
...src/simcore_service_webserver/clusters/handlers.py	34.0% <0.0%> (-63.0%)	⬇️
...ver/src/simcore_service_webserver/catalog_units.py	24.0% <0.0%> (-61.2%)	⬇️
...r/src/simcore_service_webserver/projects/_ports.py	32.9% <0.0%> (-61.0%)	⬇️
... and 659 more

[GitHK]

@GitHK @sanderegg .

As I mentioned before in mattermost: I think the problem is that the unit-tests in director-v2 are using dynamic-sidecar services as part of the setup.

With the new CI rules, any change in the dynamic-sidecar will not trigger director-v2 unit-tests . The fact that the problem is in rabbit might be a second order effect. E.g. dynamic-sidecar has changed such that rabbit is used differently and it has to be dsiabled. (this is just speculation)

My advice: let's move all unit-tests using dynamic-sidecar into integration folder or a separate one that is active when changes in the dynamic-sidecar happens

@pcrespov This is not correct. I've added a rabbitmq dependency to the dynamic-scheduler inside the director-v2. #3666

Somehow I was able to merge with the CI failing my previous PR. If you run code from master locally tests fail/hang.
The issue here is that the CI / [unit] director-v2 times out.

Somehow when you press rerun failed this is sometimes is treated as green. There is no way that the CI could have become green for CI / [unit] director-v2

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.2% Duplication