Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes flaky tests with dynamic-sidecar #3681

Merged
merged 25 commits into from
Dec 16, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 14, 2022

What do these changes do?

Fixes flaky tests in the dynamic-sidecar:

  • services/dynamic-sidecar/tests/unit/test_api_containers.py::test_outputs_watcher_disabling
  • tests/unit/test_modules_outputs_event_filter.py::test_minimum_amount_of_get_directory_total_size_calls
  • tests/unit/test_modules_outputs_watcher.py::test_port_key_sequential_event_generation

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Dec 14, 2022
@GitHK GitHK added this to the Zefram Cochrane milestone Dec 14, 2022
@GitHK GitHK marked this pull request as ready for review December 14, 2022 13:17
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #3681 (981b33d) into master (dfdd1c4) will decrease coverage by 14.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3681      +/-   ##
=========================================
- Coverage    84.4%   69.4%   -15.0%     
=========================================
  Files         883     395     -488     
  Lines       37506   20292   -17214     
  Branches      787     135     -652     
=========================================
- Hits        31664   14088   -17576     
- Misses       5632    6155     +523     
+ Partials      210      49     -161     
Flag Coverage Δ
integrationtests 67.6% <ø> (-0.1%) ⬇️
unittests 86.4% <ø> (+4.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) ⬇️
... and 673 more

@GitHK GitHK requested a review from pcrespov December 14, 2022 14:48
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have a look at this spying thing together

@GitHK GitHK changed the title 🐛 fix flaky test_outputs_watcher_disabling 🐛 fixes flaky tests with dynamic-sidecar Dec 15, 2022
@GitHK
Copy link
Contributor Author

GitHK commented Dec 15, 2022

@sanderegg @pcrespov caught a few more flaky tests and fixed here for the dynamic-sidecar

@pcrespov
Copy link
Member

@sanderegg @pcrespov caught a few more flaky tests and fixed here for the dynamic-sidecar

@GitHK if so, please list them as - close #123456 so the cases can be closed. thx

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have a look at this spying thing together

@GitHK
Copy link
Contributor Author

GitHK commented Dec 15, 2022

@sanderegg @pcrespov caught a few more flaky tests and fixed here for the dynamic-sidecar

@GitHK if so, please list them as - close #123456 so the cases can be closed. thx

there was no such entry, I've detected them today.

@GitHK GitHK enabled auto-merge (squash) December 15, 2022 19:12
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 5bbb2b3 into ITISFoundation:master Dec 16, 2022
@GitHK GitHK deleted the fix-flaky-oututs-watcher-test branch December 16, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants