-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Maintenance: disable Traefik sticky connection and Socket.IO long polling 🚨 #3686
✨ Maintenance: disable Traefik sticky connection and Socket.IO long polling 🚨 #3686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3686 +/- ##
========================================
+ Coverage 83.4% 84.3% +0.9%
========================================
Files 883 848 -35
Lines 37398 35495 -1903
Branches 786 786
========================================
- Hits 31197 29939 -1258
+ Misses 5992 5347 -645
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a 🚨 icon so we remember to test this (and, if you know some, maybe give instructions for checking this works)
Thanks a lot
@mrnicegyu11 : done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍
bd7501d
to
6041a7a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
We are in 2022, websockets are available everywhere:
Removing connection stickyness means that all webserver instances can reply to a client, instead of only one, thus this should improve responsiveness.
Reference on socket.io: https://socket.io/docs/v4/using-multiple-nodes#enabling-sticky-session
This works because currently the webserver instances are all receiving the logs/progress through rabbitMQ (very innefficient, and will be one of the next changes, so keep the hope)
Related issue/s
How to test
Checklist