Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: common redis client in service library #3689

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 15, 2022

What do these changes do?

This PR brings common code for a Redis client to be used in all services in osparc-simcore repository.

Highlights on updated libraries (only updated libraries are included)

  • #packages before: 3
  • #packages after : 2
# name before after upgrade count packages
1 deprecated 1.2.13 🗑️ removed 3 director-v2⬆️
web⬆️🧪
2 redis 4.3.4, 4.3.1 4.4.0 minor 3 director-v2⬆️
web⬆️🧪
3 wrapt 1.14.1 🗑️ removed 2 director-v2⬆️
web⬆️

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

Related issue/s

Bonus: fixes #3546

How to test

Checklist

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #3689 (3f0fd48) into master (1602748) will increase coverage by 0.2%.
The diff coverage is 95.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3689     +/-   ##
========================================
+ Coverage    83.4%   83.7%   +0.2%     
========================================
  Files         884     885      +1     
  Lines       37553   37607     +54     
  Branches      785     789      +4     
========================================
+ Hits        31356   31478    +122     
+ Misses       5987    5918     -69     
- Partials      210     211      +1     
Flag Coverage Δ
integrationtests 62.6% <100.0%> (+10.0%) ⬆️
unittests 81.5% <95.0%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../service-library/src/servicelib/background_task.py 91.1% <66.6%> (-5.7%) ⬇️
packages/service-library/src/servicelib/redis.py 98.1% <98.1%> (ø)
...simcore_service_webserver/projects/project_lock.py 94.8% <100.0%> (+4.6%) ⬆️
...ules/dynamic_sidecar/docker_service_specs/proxy.py 53.8% <0.0%> (-46.2%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 51.6% <0.0%> (-44.2%) ⬇️
...s/dynamic_sidecar/docker_service_specs/settings.py 41.5% <0.0%> (-39.5%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 71.7% <0.0%> (-28.3%) ⬇️
...r_v2/modules/dynamic_sidecar/api_client/_public.py 70.0% <0.0%> (-24.0%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 68.0% <0.0%> (-23.0%) ⬇️
...or_v2/modules/db/repositories/projects_networks.py 52.1% <0.0%> (-17.4%) ⬇️
... and 36 more

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed.

Do not forget to update downstream requirements so they also include the new redis

SEE requirements/how-to-prune-requirements.md

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

packages/service-library/tests/test_redis.py Show resolved Hide resolved
@sanderegg sanderegg force-pushed the maintenance/common_redis_client branch 2 times, most recently from 53bf7d9 to 51d4757 Compare December 15, 2022 15:38
@sanderegg sanderegg force-pushed the maintenance/common_redis_client branch from 51d4757 to 44a9e78 Compare December 15, 2022 17:14
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sanderegg sanderegg force-pushed the maintenance/common_redis_client branch from 86782a3 to ce36802 Compare December 19, 2022 08:21
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit f3f8d57 into ITISFoundation:master Dec 19, 2022
@sanderegg sanderegg deleted the maintenance/common_redis_client branch December 19, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/integration/01/test_garbage_collection.py::test_t2_cleanup_resources_after_browser_is_closed
4 participants