-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance: common redis client in service library #3689
♻️ Maintenance: common redis client in service library #3689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3689 +/- ##
========================================
+ Coverage 83.4% 83.7% +0.2%
========================================
Files 884 885 +1
Lines 37553 37607 +54
Branches 785 789 +4
========================================
+ Hits 31356 31478 +122
+ Misses 5987 5918 -69
- Partials 210 211 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair reviewed.
Do not forget to update downstream requirements so they also include the new redis
SEE requirements/how-to-prune-requirements.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
53bf7d9
to
51d4757
Compare
51d4757
to
44a9e78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
e4744e9
to
8adf822
Compare
86782a3
to
ce36802
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR brings common code for a Redis client to be used in all services in osparc-simcore repository.
Highlights on updated libraries (only updated libraries are included)
web⬆️🧪
web⬆️🧪
web⬆️
Legend:
Related issue/s
Bonus: fixes #3546
How to test
Checklist