♻️🐛 agent bug fix and improvements (⚠️ devops)

[GitHK]

⚠️ devops

• New required env var was added to the osparc_agent service named AGENT_VOLUMES_CLEANUP_TARGET_SWARM_STACK_NAME; note: service will fail to boot without it
• Set AGENT_VOLUMES_CLEANUP_TARGET_SWARM_STACK_NAME env var exactly to the same value as director-v2's SWARM_STACK_NAME env var.

What do these changes do?

• 🐛 no longer deleted volumes if an exception other than RuntimeError was raised
• ♻️ only handles the volumes coming from its own deployment. This is important for systems running multiple deployments of osparc on the same swarm. Avoids having to sift through wired upload errors which might be treated as bugs 🐛

Related issue/s

• fixes Simcore agent deletes volumes that are not properly backuped #3711
• fixes Agent only handle deployment dy-volumes #3582

How to test

Checklist

• Unit tests for the changes exist

[codecov]

Codecov Report

Merging #3712 (bedb1e6) into master (fee5d99) will decrease coverage by 0.7%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #3712     +/-   ##
========================================
- Coverage    84.5%   83.7%   -0.8%     
========================================
  Files         887     887             
  Lines       37702   37703      +1     
  Branches      790     790             
========================================
- Hits        31879   31583    -296     
- Misses       5612    5909    +297     
  Partials      211     211             

Flag	Coverage Δ
integrationtests	62.8% <ø> (-5.0%)	⬇️
unittests	81.6% <100.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mcore_service_agent/modules/volumes_cleanup/_s3.py	98.2% <ø> (ø)
...s/agent/src/simcore_service_agent/core/settings.py	93.9% <100.0%> (+0.1%)	⬆️
...ore_service_agent/modules/volumes_cleanup/_core.py	96.5% <100.0%> (+10.3%)	⬆️
...e_service_agent/modules/volumes_cleanup/_docker.py	100.0% <100.0%> (ø)
...ules/dynamic_sidecar/docker_service_specs/proxy.py	53.8% <0.0%> (-46.2%)	⬇️
...modules/dynamic_sidecar/scheduler/_core/_events.py	54.7% <0.0%> (-41.3%)	⬇️
...s/dynamic_sidecar/docker_service_specs/settings.py	41.5% <0.0%> (-39.5%)	⬇️
...s/dynamic_sidecar/scheduler/_core/_events_utils.py	61.2% <0.0%> (-30.7%)	⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py	71.7% <0.0%> (-28.3%)	⬇️
...r_v2/modules/dynamic_sidecar/api_client/_public.py	70.0% <0.0%> (-24.0%)	⬇️
... and 20 more

[mrnicegyu11]

devops changes acknowledged, thanks

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.2% Duplication