Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Edit templates: missing lock when opening dashboard #3716

Merged
merged 1 commit into from
Dec 20, 2022
Merged

🐛 Edit templates: missing lock when opening dashboard #3716

merged 1 commit into from
Dec 20, 2022

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 20, 2022 •
edited

What do these changes do?

Ensure the lock state is passed to the frontend when listing projects.
image

Related issue/s

How to test

Checklist

@sanderegg sanderegg added this to the Zefram Cochrane milestone Dec 20, 2022
@sanderegg sanderegg self-assigned this Dec 20, 2022
@sanderegg sanderegg marked this pull request as ready for review December 20, 2022 12:46
@codecov
Copy link

codecov bot commented Dec 20, 2022 •
edited

Codecov Report

Merging #3716 (a71a387) into master (a71a387) will not change coverage.
The diff coverage is n/a.

❗ Current head a71a387 differs from pull request most recent head 912055b. Consider uploading reports for the commit 912055b to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3716   +/-   ##
======================================
  Coverage    83.7%   83.7%           
======================================
  Files         887     887           
  Lines       37682   37682           
  Branches      789     789           
======================================
  Hits        31541   31541           
  Misses       5930    5930           
  Partials      211     211
Flag Coverage Δ
integrationtests 62.6% <0.0%> (ø)
unittests 81.5% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

odeimaiz
odeimaiz approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the enhancement/edit_template_missing_lock branch from 9e61df7 to c371ce4 Compare December 20, 2022 13:46
@sanderegg sanderegg force-pushed the enhancement/edit_template_missing_lock branch from c371ce4 to 912055b Compare December 20, 2022 14:13
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit 030db07 into ITISFoundation:master Dec 20, 2022
@sanderegg sanderegg deleted the enhancement/edit_template_missing_lock branch December 20, 2022 15:21
@pcrespov pcrespov mentioned this pull request Jan 5, 2023
Closed
6 tasks
@sanderegg sanderegg mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@elisabettai elisabettai Awaiting requested review from elisabettai

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Zefram Cochrane
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sanderegg @GitHK @pcrespov @odeimaiz