Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ File Upload issue in AWS: add more informative logs #3717

Merged

Conversation

sanderegg
Copy link
Member

What do these changes do?

Give more information when the 400 bad request issue arises. see #3531

Related issue/s

#3531

How to test

Checklist

@sanderegg sanderegg added this to the Zefram Cochrane milestone Dec 20, 2022
@sanderegg sanderegg self-assigned this Dec 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #3717 (cd51f6e) into master (d0c42b9) will increase coverage by 1.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3717     +/-   ##
========================================
+ Coverage    83.6%   84.7%   +1.0%     
========================================
  Files         887     654    -233     
  Lines       37682   29546   -8136     
  Branches      789     135    -654     
========================================
- Hits        31533   25037   -6496     
+ Misses       5938    4461   -1477     
+ Partials      211      48    -163     
Flag Coverage Δ
integrationtests 62.6% <ø> (+<0.1%) ⬆️
unittests 82.0% <ø> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_sdk/node_ports_common/file_io_utils.py 88.3% <ø> (ø)
...tion_services_catalog/services/iter_sensitivity.py
...y/function_services_catalog/services/demo_units.py
...e/src/simcore_postgres_database/models/clusters.py
...ckages/models-library/src/models_library/errors.py
...ackages/service-library/src/servicelib/observer.py
...abase/src/simcore_postgres_database/models/base.py
.../service-library/src/servicelib/fastapi/tracing.py
...src/simcore_postgres_database/models/comp_tasks.py
...ase/src/simcore_postgres_database/models/tokens.py
... and 228 more

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants