-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Fix/storage skip invalid projects while listing #3740
馃悰 Fix/storage skip invalid projects while listing #3740
Conversation
74bc6ce
to
6721b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 馃挭
Codecov Report
@@ Coverage Diff @@
## master #3740 +/- ##
=========================================
- Coverage 79.8% 62.9% -16.9%
=========================================
Files 776 264 -512
Lines 32125 13377 -18748
Branches 791 0 -791
=========================================
- Hits 25636 8424 -17212
+ Misses 6291 4953 -1338
+ Partials 198 0 -198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair-fixed. Thanks!
Code Climate has analyzed commit df05c01 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!聽 聽 0 Bugs No Coverage information |
What do these changes do?
@drniiken could not copy a template project that he owned. This was a side effect of having corrupted data in both
projects
andmeta_data
tables. The copy routine was failing because a validation error on some data owned by the same user. The corrupt data had nothing to do with this operation but the error was not handled properly which resulted in a confusing 400 error withmessage=Invalid header token
Running the same request from storage i.e.
GET http://storage:8080/v0/locations/0/files/metadata?user_id=5&uuid_filter=b7...
revealed the validation error.Two actions were taken:
This should prevent for the moment this error but does not completely solves the problem. Follow up should consider adding validation tests against deployed databases: