Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fixes flaky tests/unit/with_dbs/test_modules_redis.py::test_acquire_all_available_node_locks_stress_test #3751

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 12, 2023

What do these changes do?

  • Due to how the Lock's TTL extend scripts are initialised internally, sometimes these would end up missing upon creation. Making sure these are present.
  • wrong timeout interval, it was halved instead of being multiplied 馃か

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Jan 12, 2023
@GitHK GitHK added changelog:馃悰bugfix a:director-v2 issue related with the director-v2 service labels Jan 12, 2023
@GitHK GitHK added this to the ZeframCochrane+1 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #3751 (4f99472) into master (ecdb357) will decrease coverage by 13.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3751      +/-   ##
=========================================
- Coverage    84.8%   70.9%   -14.0%     
=========================================
  Files         915     374     -541     
  Lines       38648   18988   -19660     
  Branches      793     135     -658     
=========================================
- Hits        32790   13463   -19327     
+ Misses       5646    5476     -170     
+ Partials      212      49     -163     
Flag Coverage 螖
integrationtests 61.8% <33.3%> (-5.0%) 猬囷笍
unittests 86.4% <100.0%> (+4.4%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...simcore_service_director_v2/modules/node_rights.py 98.1% <100.0%> (-0.9%) 猬囷笍
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) 猬囷笍
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) 猬囷笍
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) 猬囷笍
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) 猬囷笍
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) 猬囷笍
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) 猬囷笍
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) 猬囷笍
...ce_webserver/studies_dispatcher/_studies_access.py 22.7% <0.0%> (-63.7%) 猬囷笍
...ver/src/simcore_service_webserver/catalog_units.py 24.0% <0.0%> (-61.2%) 猬囷笍
... and 691 more

@GitHK GitHK marked this pull request as ready for review January 12, 2023 14:37
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super, thanks

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK GitHK enabled auto-merge (squash) January 12, 2023 15:00
@codeclimate
Copy link

codeclimate bot commented Jan 13, 2023

Code Climate has analyzed commit 4f99472 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 6e932c9 into ITISFoundation:master Jan 13, 2023
@GitHK GitHK deleted the flaky-test-dv2-node-rights branch January 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants