-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 agent handles volumes with labels set to None #3757
🐛 agent handles volumes with labels set to None #3757
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3757 +/- ##
=========================================
- Coverage 84.8% 52.6% -32.2%
=========================================
Files 915 387 -528
Lines 38654 19316 -19338
Branches 793 135 -658
=========================================
- Hits 32790 10172 -22618
- Misses 5652 9095 +3443
+ Partials 212 49 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. some minors
services/agent/src/simcore_service_agent/modules/volumes_cleanup/_docker.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Code Climate has analyzed commit aa12d42 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Apparently listing volumes via
aiodocker
can produce a volume with{"Labels": None}
. This addresses a subtle issue with it.Related issue/s
How to test
Checklist