Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 agent handles volumes with labels set to None #3757

Merged
merged 6 commits into from
Jan 16, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 13, 2023

What do these changes do?

Apparently listing volumes via aiodocker can produce a volume with {"Labels": None}. This addresses a subtle issue with it.

  • ♻️ merged test files with similar names
  • 🐛added regression test for issue and fixed it

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #3757 (aa12d42) into master (3151649) will decrease coverage by 32.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3757      +/-   ##
=========================================
- Coverage    84.8%   52.6%   -32.2%     
=========================================
  Files         915     387     -528     
  Lines       38654   19316   -19338     
  Branches      793     135     -658     
=========================================
- Hits        32790   10172   -22618     
- Misses       5652    9095    +3443     
+ Partials      212      49     -163     
Flag Coverage Δ
integrationtests 51.9% <ø> (-15.0%) ⬇️
unittests 96.3% <100.0%> (+14.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_service_agent/modules/volumes_cleanup/_docker.py 100.0% <100.0%> (ø)
...s/web/server/src/simcore_service_webserver/tags.py 0.0% <0.0%> (-100.0%) ⬇️
...web/server/src/simcore_service_webserver/groups.py 0.0% <0.0%> (-100.0%) ⬇️
...eb/server/src/simcore_service_webserver/storage.py 0.0% <0.0%> (-100.0%) ⬇️
...b/server/src/simcore_service_webserver/users_db.py 0.0% <0.0%> (-100.0%) ⬇️
...rver/src/simcore_service_webserver/publications.py 0.0% <0.0%> (-100.0%) ⬇️
...ver/src/simcore_service_webserver/meta_modeling.py 0.0% <0.0%> (-100.0%) ⬇️
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...er/src/simcore_service_webserver/exporter/utils.py 0.0% <0.0%> (-100.0%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 0.0% <0.0%> (-100.0%) ⬇️
... and 772 more

@GitHK GitHK marked this pull request as ready for review January 13, 2023 11:27
@GitHK GitHK added this to the ZeframCochrane+1 milestone Jan 13, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. some minors

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codeclimate
Copy link

codeclimate bot commented Jan 16, 2023

Code Climate has analyzed commit aa12d42 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK enabled auto-merge (squash) January 16, 2023 08:26
@GitHK GitHK merged commit dcf1090 into ITISFoundation:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants