Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update e2e packages #3762

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 15, 2023

What do these changes do?

  • Update packages
    "jest": "^24.9.0" -> "^29.3.1"
    "jest-puppeteer": "^4.4.0" -> "^6.2.0"
    "log4js": "^6.4.0" -> "^6.7.1"
    "node-fetch": "^2.6.1" -> "^3.3.0"
    "puppeteer": "^2.1.1" -> "^19.5.2"
  • Update jest related tests

Next step: Update the itisfoundation/puppeteer:14 base image that is used by gitlab.

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the t:maintenance Some planned maintenance work label Jan 15, 2023
@odeimaiz odeimaiz added this to the ZeframCochrane+1 milestone Jan 15, 2023
@odeimaiz odeimaiz self-assigned this Jan 15, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15241 lines exceeds the maximum allowed for the inline comments feature.

@odeimaiz odeimaiz changed the title ⬆️ Update e2e packages WIP: ⬆️ Update e2e packages Jan 15, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15256 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15256 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15272 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15276 lines exceeds the maximum allowed for the inline comments feature.

@odeimaiz odeimaiz marked this pull request as ready for review January 16, 2023 15:38
@odeimaiz odeimaiz changed the title WIP: ⬆️ Update e2e packages ⬆️ Update e2e packages Jan 16, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15280 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 15280 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jan 18, 2023

Code Climate has analyzed commit 4bf1eb9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants