-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is3683/invitations webserver check #3767
✨ Is3683/invitations webserver check #3767
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3767 +/- ##
======================================
Coverage 81.8% 81.8%
======================================
Files 916 916
Lines 38967 38967
Branches 793 793
======================================
Hits 31887 31887
Misses 6883 6883
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. |
c9dc00a
to
b37de73
Compare
b37de73
to
3b39a39
Compare
0aa413f
to
166810a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some minor suggestions.
services/web/server/src/simcore_service_webserver/invitations_core.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/invitations_core.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/login/_registration.py
Outdated
Show resolved
Hide resolved
b714e49
to
8f27d81
Compare
Code Climate has analyzed commit 8f27d81 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Implements new invitations check on the web-server
web/server/invitations
plugin to interact with theinvitations
serviceinvitations_settings.py
: plugin settingsinvitations_client.py
: SDK to interact with the service http API.invitations.py
: exposes plugin API (free functions and exceptions) andsetup_*
functionweb/server/login
plugininvitations
serviceRelated issue/s
How to test
WEBSERVER_LOGIN_REGISTRATION_CONFIRMATION_REQUIRED=1
andWEBSERVER_LOGIN_REGISTRATION_INVITATION_REQUIRED=1
in.env
file.invitations service API
. Link and credentials are listed in the table aftermake up
asInvitations
)Checklist