Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is3683/invitations webserver check #3767

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 16, 2023

What do these changes do?

Implements new invitations check on the web-server

  • ✨ New web/server/invitations plugin to interact with the invitations service
    • invitations_settings.py: plugin settings
    • invitations_client.py: SDK to interact with the service http API.
      • setup/tear-down client session
      • exposes service API
    • invitations.py: exposes plugin API (free functions and exceptions) and setup_* function
  • ✨ Adds new invitations check in web/server/login plugin
  • 🔨 Cleanup scripts in invitations service
  • 📝 Cleanup badges in README

Related issue/s

How to test

  • unit tested with coverage >85%
  • manually
  1. set WEBSERVER_LOGIN_REGISTRATION_CONFIRMATION_REQUIRED=1 and WEBSERVER_LOGIN_REGISTRATION_INVITATION_REQUIRED=1 in .env file.
  2. Generate invitation link (e.g. use invitations service API. Link and credentials are listed in the table after make up as Invitations)
  3. Add link in browser and follow instructions in the UI to register a user

Checklist

  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes

@pcrespov pcrespov self-assigned this Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #3767 (99db5b7) into master (99db5b7) will not change coverage.
The diff coverage is n/a.

❗ Current head 99db5b7 differs from pull request most recent head 8f27d81. Consider uploading reports for the commit 8f27d81 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3767   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files         916     916           
  Lines       38967   38967           
  Branches      793     793           
======================================
  Hits        31887   31887           
  Misses       6883    6883           
  Partials      197     197           
Flag Coverage Δ
integrationtests 73.1% <0.0%> (ø)
unittests 80.9% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pcrespov pcrespov force-pushed the is3683/invitations-webserver-check branch from c9dc00a to b37de73 Compare January 16, 2023 21:29
@pcrespov pcrespov mentioned this pull request Jan 16, 2023
8 tasks
@pcrespov pcrespov force-pushed the is3683/invitations-webserver-check branch from b37de73 to 3b39a39 Compare January 17, 2023 10:28
@pcrespov pcrespov added this to the Resistance Is Futile milestone Jan 18, 2023
@pcrespov pcrespov force-pushed the is3683/invitations-webserver-check branch 2 times, most recently from 0aa413f to 166810a Compare January 20, 2023 16:10
@pcrespov pcrespov changed the title WIP: ✨ Is3683/invitations webserver check ✨ Is3683/invitations webserver check Jan 20, 2023
@pcrespov pcrespov marked this pull request as ready for review January 20, 2023 17:58
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jan 20, 2023
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some minor suggestions.

@pcrespov pcrespov enabled auto-merge (squash) January 23, 2023 10:47
@pcrespov pcrespov force-pushed the is3683/invitations-webserver-check branch from b714e49 to 8f27d81 Compare January 23, 2023 11:21
@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit 8f27d81 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 402c8c7 into ITISFoundation:master Jan 23, 2023
@pcrespov pcrespov deleted the is3683/invitations-webserver-check branch January 23, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants