Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fixes invitation_required value in /config #3772

Merged
merged 10 commits into from
Jan 17, 2023

Conversation

pcrespov
Copy link
Member

What do these changes do?

Fixes value of invitation_required in /config. This configuration depends on the product now and it was returned the app-level config instead.

Related issue/s

How to test

Checklist

@pcrespov pcrespov changed the title 馃悰 Fix/product public config 馃悰 Fixes invitation_required value in /config Jan 17, 2023
@pcrespov pcrespov self-assigned this Jan 17, 2023
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 馃憤

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #3772 (e5f3d5b) into master (418206d) will decrease coverage by 1.2%.
The diff coverage is 89.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3772      +/-   ##
=========================================
- Coverage    80.9%   79.7%    -1.2%     
=========================================
  Files         880     228     -652     
  Lines       36860   11691   -25169     
  Branches      791       0     -791     
=========================================
- Hits        29829    9322   -20507     
+ Misses       6821    2369    -4452     
+ Partials      210       0     -210     
Flag Coverage 螖
integrationtests ?
unittests 79.7% <89.1%> (+1.0%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...rver/src/simcore_service_webserver/login/plugin.py 89.8% <78.9%> (+0.6%) 猬嗭笍
...server/src/simcore_service_webserver/_constants.py 100.0% <100.0%> (酶)
.../simcore_service_webserver/application_settings.py 98.6% <100.0%> (-0.1%) 猬囷笍
...ver/src/simcore_service_webserver/rest_handlers.py 87.1% <100.0%> (+2.3%) 猬嗭笍
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-63.5%) 猬囷笍
...simcore_service_webserver/computation_subscribe.py 35.5% <0.0%> (-62.8%) 猬囷笍
...r/src/simcore_service_webserver/projects/_ports.py 32.9% <0.0%> (-61.0%) 猬囷笍
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-58.6%) 猬囷笍
...imcore_service_webserver/garbage_collector_task.py 27.9% <0.0%> (-58.2%) 猬囷笍
...vice_webserver/exporter/formatters/formatter_v1.py 27.6% <0.0%> (-55.9%) 猬囷笍
... and 734 more

@pcrespov pcrespov added a:webserver issue related to the webserver service changelog:馃悰bugfix labels Jan 17, 2023
@pcrespov pcrespov added this to the Resistance Is Futile milestone Jan 17, 2023
@pcrespov pcrespov enabled auto-merge (squash) January 17, 2023 21:20
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit e5f3d5b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit f5407b2 into ITISFoundation:master Jan 17, 2023
@pcrespov pcrespov deleted the fix/product_public_config branch January 17, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants