Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Maintenance Tracker II #3785

Merged
merged 8 commits into from
Jan 20, 2023
Merged

✨ Maintenance Tracker II #3785

merged 8 commits into from
Jan 20, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 20, 2023 •
edited

What do these changes do?

Keep asking every 20' in case there are updates:

  • React to Redis' maintenance entry changes
    • Update notification/logout if maintenance is updated
    • Remove it if maintenance is removed

maintenance

Related issue/s

related to #3784: UI: force logout users only between the time span (begin, end] of maintenance

How to test

Checklist

@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Jan 20, 2023
@odeimaiz odeimaiz self-assigned this Jan 20, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 20, 2023

Code Climate has analyzed commit d7d23a0 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz marked this pull request as ready for review January 20, 2023 13:05
@odeimaiz odeimaiz changed the title WIP: ✨ Maintenance Tracker II ✨ Maintenance Tracker II Jan 20, 2023
@odeimaiz odeimaiz enabled auto-merge (squash) January 20, 2023 13:08
pcrespov
pcrespov approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

elisabettai
elisabettai reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@odeimaiz odeimaiz merged commit cca02d0 into ITISFoundation:master Jan 20, 2023
@pcrespov pcrespov mentioned this pull request Jan 26, 2023
Closed
12 tasks
@sanderegg sanderegg mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabettai elisabettai elisabettai left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@Surfict Surfict Awaiting requested review from Surfict

Assignees

@odeimaiz odeimaiz

Labels
None yet
Projects
None yet
Milestone
Resistance Is Futile
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@odeimaiz @elisabettai @pcrespov @sanderegg