Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Study/Template/Service permissions #3792

Merged
merged 20 commits into from
Jan 25, 2023
Merged

✨ Study/Template/Service permissions #3792

merged 20 commits into from
Jan 25, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 24, 2023 •
edited

What do these changes do?

Expose to the frontend more member access rights operations:

  • Owners (read, write, delete) can:
    • Promote Collaborators to Owners
    • Demote other Owners to Collaborators
    • Remove others
  • Collaborators (read, write) can:
    • Promote Collaborators to Collaborators
    • Demote other Collaborators to Viewers
    • Remove others
  • Viewers (read) can:
    • No operations

Bonus:

  • Organizations: Promote to Admin and Demote to Member

ShareStudy

Related issue/s

closes ITISFoundation/osparc-issues#843
closes ITISFoundation/osparc-issues#837

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Jan 24, 2023
@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Jan 24, 2023
@odeimaiz odeimaiz self-assigned this Jan 24, 2023
@odeimaiz odeimaiz changed the title WIP: Roles WIP: Study permissions Jan 24, 2023
@odeimaiz odeimaiz changed the title WIP: Study permissions WIP: ✨ Study permissions Jan 24, 2023
@odeimaiz odeimaiz changed the title WIP: ✨ Study permissions WIP: ✨ Study/Template/Service permissions Jan 24, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit 1a9c73a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz changed the title WIP: ✨ Study/Template/Service permissions ✨ Study/Template/Service permissions Jan 24, 2023
@odeimaiz odeimaiz marked this pull request as ready for review January 24, 2023 15:58
@odeimaiz odeimaiz enabled auto-merge (squash) January 24, 2023 15:59
pcrespov
pcrespov reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GitHK
GitHK approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

services/static-webserver/client/source/class/osparc/ui/list/CollaboratorListItem.js Show resolved Hide resolved
services/static-webserver/client/source/class/osparc/ui/list/CollaboratorListItem.js Show resolved Hide resolved
@odeimaiz odeimaiz merged commit 866c343 into ITISFoundation:master Jan 25, 2023
@pcrespov pcrespov mentioned this pull request Jan 26, 2023
Closed
12 tasks
@sanderegg sanderegg mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@cosfor1 cosfor1 Awaiting requested review from cosfor1

@elisabettai elisabettai Awaiting requested review from elisabettai

@mguidon mguidon Awaiting requested review from mguidon

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Resistance Is Futile
Development

Successfully merging this pull request may close these issues.

Study owners can demote other owners Access service resources from the workbench
3 participants
@odeimaiz @GitHK @pcrespov