Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Frontend: Notify New Release #3807

Merged
merged 29 commits into from
Jan 27, 2023
Merged

✨ Frontend: Notify New Release #3807

merged 29 commits into from
Jan 27, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 26, 2023 •
edited

What do these changes do?

Based on the vcsRefClient that backend provides, if it's different to the one previously stored in the browser's localStorage, pop up a dialog notifying the user that a new release was deployed.

  • Show New Release dialog
  • [ ] Provide a hard refresh button/method Dropped, I tried many things but they didn't work :(

NewRelease

Related issue/s

ITISFoundation/osparc-issues#765

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jan 26, 2023
@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Jan 26, 2023
@odeimaiz odeimaiz self-assigned this Jan 26, 2023
@odeimaiz odeimaiz changed the title WIP: ✨ Frontend: Show New Release WIP: ✨ Frontend: Notify New Release Jan 26, 2023
@odeimaiz odeimaiz changed the title WIP: ✨ Frontend: Notify New Release ✨ Frontend: Notify New Release Jan 27, 2023
@odeimaiz odeimaiz marked this pull request as ready for review January 27, 2023 11:22
@odeimaiz odeimaiz enabled auto-merge (squash) January 27, 2023 11:26
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2023

Code Climate has analyzed commit 9c14be4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pcrespov
pcrespov approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will provide you later with more info on the release tag so you can add also a link to the change log which are more human-readable than the list of commits. But in any case, this solution is great provided the info we have!
thx

@odeimaiz odeimaiz merged commit 1d8a7da into ITISFoundation:master Jan 27, 2023
@sanderegg sanderegg mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

@GitHK GitHK Awaiting requested review from GitHK

@elisabettai elisabettai Awaiting requested review from elisabettai

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Resistance Is Futile
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odeimaiz @pcrespov @sanderegg