Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Removing overlay from docker-compose spec #3821

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 31, 2023

What do these changes do?

The art of copy and pasting is something very few manage to master. I am really bad at it.馃う

PR #3606 broke the sidecars not running on manager nodes.
Removed overlay driver from the service docker-compose spec. The node needs to be a swarm manager in order to use it. It is also not necessary in this case.

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Jan 31, 2023
@GitHK GitHK added changelog:馃悰bugfix a:director-v2 issue related with the director-v2 service a:dynamic-sidecar dynamic-sidecar service labels Jan 31, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Jan 31, 2023
@GitHK GitHK marked this pull request as ready for review January 31, 2023 09:02
@GitHK GitHK requested a review from mguidon January 31, 2023 09:02
@codeclimate
Copy link

codeclimate bot commented Jan 31, 2023

Code Climate has analyzed commit c9dc642 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #3821 (c9dc642) into master (1023d36) will decrease coverage by 11.2%.
The diff coverage is 0.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3821      +/-   ##
=========================================
- Coverage    84.8%   73.7%   -11.2%     
=========================================
  Files         924     415     -509     
  Lines       39507   21450   -18057     
  Branches      810     136     -674     
=========================================
- Hits        33517   15810   -17707     
+ Misses       5778    5591     -187     
+ Partials      212      49     -163     
Flag Coverage 螖
integrationtests 66.6% <0.0%> (+<0.1%) 猬嗭笍
unittests 85.9% <0.0%> (+3.9%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...es/dynamic_sidecar/docker_compose_egress_config.py 57.7% <0.0%> (酶)
...simcore_service_dynamic_sidecar/core/validation.py 76.6% <酶> (酶)
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) 猬囷笍
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) 猬囷笍
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) 猬囷笍
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) 猬囷笍
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) 猬囷笍
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) 猬囷笍
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) 猬囷笍
...ce_webserver/studies_dispatcher/_studies_access.py 22.7% <0.0%> (-63.7%) 猬囷笍
... and 648 more

@GitHK GitHK enabled auto-merge (squash) January 31, 2023 10:09
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GitHK GitHK merged commit 51c9bd0 into ITISFoundation:master Jan 31, 2023
@GitHK GitHK deleted the pr-osparc-fix-network-drivers branch January 31, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants