-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Removing overlay from docker-compose spec #3821
馃悰 Removing overlay from docker-compose spec #3821
Conversation
Code Climate has analyzed commit c9dc642 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!聽 聽 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #3821 +/- ##
=========================================
- Coverage 84.8% 73.7% -11.2%
=========================================
Files 924 415 -509
Lines 39507 21450 -18057
Branches 810 136 -674
=========================================
- Hits 33517 15810 -17707
+ Misses 5778 5591 -187
+ Partials 212 49 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
What do these changes do?
The art of copy and pasting is something very few manage to master. I am really bad at it.馃う
PR #3606 broke the sidecars not running on manager nodes.
Removed
overlay
driver from the service docker-compose spec. The node needs to be a swarm manager in order to use it. It is also not necessary in this case.Related issue/s
How to test
Checklist