Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 issues with docker networking and DNS resolution #3826

Merged
merged 22 commits into from
Feb 3, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 1, 2023

What do these changes do?

  • Issue1: Using an overlay network for Envoy, will break its internal DNS resolver. Replaced overlay network with normal docker network.
  • Issue2: Internal in house DNS domain server is never resolved but Envoy's DNS recover. Removed force search using TCP to solve queries. UDP is the default and what all servers support.
  • Other: fixing typos regarding the envoy word.

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #3826 (6f82c6d) into master (407bd60) will increase coverage by 2.7%.
The diff coverage is 11.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3826      +/-   ##
=========================================
+ Coverage    83.2%   85.9%    +2.7%     
=========================================
  Files         927     126     -801     
  Lines       39699    6338   -33361     
  Branches      836       0     -836     
=========================================
- Hits        33046    5447   -27599     
+ Misses       6446     891    -5555     
+ Partials      207       0     -207     
Flag Coverage Δ
integrationtests ?
unittests 85.9% <11.1%> (+3.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...2/src/simcore_service_director_v2/core/settings.py 98.4% <ø> (ø)
...v2/modules/dynamic_sidecar/docker_compose_specs.py 69.5% <ø> (ø)
...es/dynamic_sidecar/docker_compose_egress_config.py 56.7% <11.1%> (-1.1%) ⬇️
...server/src/simcore_service_webserver/login/_2fa.py
...rc/simcore_service_webserver/scicrunch/settings.py
...eb/server/src/simcore_service_webserver/statics.py
...s-library/src/models_library/services_resources.py
...ings-library/src/settings_library/utils_logging.py
.../simcore_sdk/node_ports_common/data_items_utils.py
...mcore_postgres_database/models/jinja2_templates.py
... and 797 more

@GitHK GitHK marked this pull request as ready for review February 2, 2023 17:38
@GitHK GitHK requested a review from mguidon February 2, 2023 17:38
@GitHK GitHK self-assigned this Feb 2, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Feb 2, 2023
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I get it right, you are testing these NAT rules before setting them?
Please check my comments.

@GitHK
Copy link
Contributor Author

GitHK commented Feb 3, 2023

@sanderegg @pcrespov sorry. Just realised this morning what was happening with the DNS resolver. It required UDP and not TCP searching. That's why some servers were not resolving addresses.

@GitHK GitHK requested a review from sanderegg February 3, 2023 07:48
@GitHK GitHK requested a review from pcrespov February 3, 2023 07:59
@GitHK GitHK enabled auto-merge (squash) February 3, 2023 08:01
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2023

Code Climate has analyzed commit 6f82c6d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit 60e0c84 into ITISFoundation:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants