-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 issues with docker networking and DNS resolution #3826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3826 +/- ##
=========================================
+ Coverage 83.2% 85.9% +2.7%
=========================================
Files 927 126 -801
Lines 39699 6338 -33361
Branches 836 0 -836
=========================================
- Hits 33046 5447 -27599
+ Misses 6446 891 -5555
+ Partials 207 0 -207
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I get it right, you are testing these NAT rules before setting them?
Please check my comments.
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_compose_egress_config.py
Outdated
Show resolved
Hide resolved
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_compose_egress_config.py
Outdated
Show resolved
Hide resolved
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_compose_egress_config.py
Outdated
Show resolved
Hide resolved
@sanderegg @pcrespov sorry. Just realised this morning what was happening with the DNS resolver. It required UDP and not TCP searching. That's why some servers were not resolving addresses. |
...r-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_compose_egress_config.py
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 6f82c6d and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
envoy
word.Related issue/s
How to test
Checklist