🐛 Fixes #1517: project tags are copied when cloned

[pcrespov]

What do these changes do?

• 🐛 Project clone was not copying tag references (i.e. original tags are referenced)
  

• ♻️ Refactors projects_db module of the webserver's service projects plugin. This is how it looks now
  

Related issue/s

• Ongoing implementation of Refactor ProjectDBAPI and project models #3516 : splits away helpers from many body and cleanup dbapi interface for CRUD calls
• Fixes Copy Tags from template2study and study2template #1517

How to test

• create a study
• Add tags
• Clone it
• Tags should get copied
• Change/delete one of the tags in the preferences
• Tag in the cloned study should have changed

Checklist

• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes

[codecov]

Codecov Report

Merging #3828 (742b2a4) into master (83c4a94) will decrease coverage by 0.9%.
The diff coverage is 89.6%.

@@           Coverage Diff            @@
##           master   #3828     +/-   ##
========================================
- Coverage    84.8%   84.0%   -0.9%     
========================================
  Files         925     926      +1     
  Lines       39558   39588     +30     
  Branches      819     819             
========================================
- Hits        33555   33257    -298     
- Misses       5786    6114    +328     
  Partials      217     217             

Flag	Coverage Δ
integrationtests	66.6% <81.1%> (+<0.1%)	⬆️
unittests	81.0% <86.5%> (-1.0%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e/src/simcore_postgres_database/models/projects.py	100.0% <ø> (ø)
...imcore_service_webserver/garbage_collector_core.py	61.3% <ø> (-0.6%)	⬇️
...vice_webserver/projects/projects_ports_handlers.py	59.6% <0.0%> (-34.5%)	⬇️
...mcore_service_webserver/projects/projects_utils.py	83.5% <ø> (-3.9%)	⬇️
...simcore_service_webserver/projects/projects_api.py	75.6% <50.0%> (-18.0%)	⬇️
.../simcore_service_webserver/projects/projects_db.py	88.2% <88.9%> (-8.3%)	⬇️
...re_service_webserver/projects/projects_db_utils.py	92.0% <92.0%> (ø)
...vice_webserver/exporter/formatters/formatter_v1.py	83.5% <100.0%> (ø)
.../src/simcore_service_webserver/projects/_delete.py	74.5% <100.0%> (-3.7%)	⬇️
...rvice_webserver/projects/projects_handlers_crud.py	71.2% <100.0%> (-21.9%)	⬇️
... and 20 more

[odeimaiz]

Thanks 👍

[sanderegg]

great, please have a look at the comments. thanks!

[GitHK]

Some comments. I could not identify where the fix regarding the issue is.

[codeclimate]

Code Climate has analyzed commit 742b2a4 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication