♻️ enhances emails plugin and 🐛 fixes missing fields ( ⚠️ devops ) #3822

[pcrespov]

What do these changes do?

Follows up on #3822: emails sent by osparc are classified as spam because some fields are missing. This PR adds missing MIME fields and creates a new entrypoint to test emails directly in the deploy (admin privileges needed). This should help spotting other issues that might be missing in the email server configured in the stack.

⚠️ devops:

There should be one (and one only) admin account per deployment (for now, best with mail our common devops mail adress osparcio-devops =at= speag.swiss). No other user (even team members) should have admin privileges. The admin-account will go into the e2e-ops, into the credentials page. This needs to be done upon releasing this PR.

Hightlights

• ♻️ Moves email and text templates helpers to email plugin
  • New POST /email:test for admin to manually test templates and email server (i.e. admin privileges required)
• 🐛 Completes required MIME date field

Related issue/s

• closes 🐛 Add MIME date field to mails  #3822

How to test

• New entrypoint was designed to manually test with the actual email server

Checklist

• make version-*
• make openapi.json
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes

[codecov]

Codecov Report

Merging #3835 (503ea4c) into master (d4874cb) will increase coverage by 5.1%.
The diff coverage is 79.4%.

@@           Coverage Diff            @@
##           master   #3835     +/-   ##
========================================
+ Coverage    81.5%   86.7%   +5.1%     
========================================
  Files         883     747    -136     
  Lines       38876   33017   -5859     
  Branches      766     393    -373     
========================================
- Hits        31721   28646   -3075     
+ Misses       6963    4262   -2701     
+ Partials      192     109     -83     

Flag	Coverage Δ
integrationtests	52.3% <50.6%> (?)
unittests	84.6% <79.4%> (+3.0%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../web/server/src/simcore_service_webserver/utils.py	56.3% <66.6%> (+0.4%)	⬆️
...server/src/simcore_service_webserver/email_core.py	72.2% <72.2%> (ø)
...er/src/simcore_service_webserver/email_handlers.py	91.3% <91.3%> (ø)
.../web/server/src/simcore_service_webserver/email.py	93.7% <100.0%> (+0.8%)	⬆️
...src/simcore_service_webserver/login/utils_email.py	93.3% <100.0%> (+26.2%)	⬆️
...er/src/simcore_service_webserver/security_roles.py	100.0% <100.0%> (ø)
...elib/fastapi/long_running_tasks/_error_handlers.py
...c/servicelib/aiohttp/long_running_tasks/_server.py
...rvice-library/src/servicelib/aiohttp/monitoring.py
...dask_task_models_library/container_tasks/docker.py
... and 275 more

[mrnicegyu11]

Thanks a lot, truly <3 !

[GitHK]

👍

[codeclimate]

Code Climate has analyzed commit 503ea4c and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication