Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: Window too small message to ribbon #3838

Merged
merged 15 commits into from
Feb 6, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 6, 2023

What do these changes do?

This PR changes the notification system for small screens.

We used to have a (too annoying) pop up message in the center of the window. This PR will replace it with a message on the ribbon.

tooSmall

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Feb 6, 2023
@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Feb 6, 2023
@odeimaiz odeimaiz self-assigned this Feb 6, 2023
@odeimaiz odeimaiz changed the title ✨ Frontend: Window too small message on ribbon ✨ Frontend: Window too small message to ribbon Feb 6, 2023
@odeimaiz odeimaiz marked this pull request as ready for review February 6, 2023 14:05
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of Lizzy 👍 ;-)

@odeimaiz odeimaiz enabled auto-merge (squash) February 6, 2023 14:12
@codeclimate
Copy link

codeclimate bot commented Feb 6, 2023

Code Climate has analyzed commit fba5f3e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@odeimaiz odeimaiz merged commit 4723546 into ITISFoundation:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants