-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ director-v2 api client enhancements #3839
♻️ director-v2 api client enhancements #3839
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3839 +/- ##
=========================================
- Coverage 84.0% 72.4% -11.6%
=========================================
Files 892 381 -511
Lines 37746 19521 -18225
Branches 837 137 -700
=========================================
- Hits 31721 14145 -17576
+ Misses 5804 5327 -477
+ Partials 221 49 -172
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/director-v2/tests/unit/test_modules_dynamic_sidecar_client_api_base.py
Show resolved
Hide resolved
...ices/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/api_client/_thin.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair reviewed.
pls remove duplicated client.
txh
Code Climate has analyzed commit 6ada13a and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Apparently the dynamic-schedueler is eating up all connections in the http client used to talk to the dy-sidecars. This causes the director to stop talking to them.
This tries to add more details about what is happening to the connection pool.
Related issue/s
How to test
Checklist