Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ director-v2 api client enhancements #3839

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 6, 2023

What do these changes do?

Apparently the dynamic-schedueler is eating up all connections in the http client used to talk to the dy-sidecars. This causes the director to stop talking to them.

This tries to add more details about what is happening to the connection pool.

  • using correct instance of the client (no longer creating a new one)
  • better pool usage details

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@GitHK GitHK self-assigned this Feb 6, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Feb 6, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #3839 (6ada13a) into master (4723546) will decrease coverage by 11.6%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3839      +/-   ##
=========================================
- Coverage    84.0%   72.4%   -11.6%     
=========================================
  Files         892     381     -511     
  Lines       37746   19521   -18225     
  Branches      837     137     -700     
=========================================
- Hits        31721   14145   -17576     
+ Misses       5804    5327     -477     
+ Partials      221      49     -172     
Flag Coverage Δ
integrationtests 66.7% <83.3%> (+5.0%) ⬆️
unittests 85.8% <100.0%> (+3.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/api_client/_base.py 98.6% <100.0%> (+1.3%) ⬆️
...tor_v2/modules/dynamic_sidecar/api_client/_thin.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) ⬇️
...ce_webserver/studies_dispatcher/_studies_access.py 22.7% <0.0%> (-63.7%) ⬇️
... and 665 more

@GitHK GitHK marked this pull request as ready for review February 6, 2023 12:38
@GitHK GitHK requested a review from mguidon February 6, 2023 12:38
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed.
pls remove duplicated client.
txh

@codeclimate
Copy link

codeclimate bot commented Feb 6, 2023

Code Climate has analyzed commit 6ada13a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK merged commit d4874cb into ITISFoundation:master Feb 6, 2023
@GitHK GitHK deleted the dv2-api-client-enhancements branch February 6, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants