✨ Directorv2: adds current product_name in ScheduledData [part 2 of #3565]

[pcrespov]

What do these changes do?

Follows from PR #3803. This PR simply gets information about the current product (i.e. product_name) into the directorv2 ScheduledData so it can be used to determine the context for OSPARC_ENVIRONMENT_-identifiers substitution.

Due to the large amount of changes, the next PR will introduce the mechanism that resolves OSPARC_ENVIRONMENT_-identifiers depending on the context (i.e. user_id, project_uid, product_name, etc)

Changes highlights:

• ✨ directorv2 API 2.1.0 → 2.2.0
  • NEW product_name required in API (breaks backwards compatibility)
  • when a service gets scheduled, it also captures the current product_name in ScheduledData
• ♻️ cleanup test_utils_string_substitution.py

Related issue/s

• Implements part of Pass deployment variables to service containers #3565: changes in director-v2

How to test

• directorv2 and webserver tests in-place

Checklist

• make version-*
• make openapi.json
• Unit tests for the changes exist
• Runs in the swarm

[codecov]

Codecov Report

Merging #3843 (1eee98a) into master (35cce4f) will increase coverage by 0.7%.
The diff coverage is 100.0%.

❗ Current head 1eee98a differs from pull request most recent head b415f9a. Consider uploading reports for the commit b415f9a to get more accurate results

@@           Coverage Diff            @@
##           master   #3843     +/-   ##
========================================
+ Coverage    82.9%   83.7%   +0.7%     
========================================
  Files         929     815    -114     
  Lines       39836   36424   -3412     
  Branches      837     485    -352     
========================================
- Hits        33043   30496   -2547     
+ Misses       6572    5800    -772     
+ Partials      221     128     -93     

Flag	Coverage Δ
integrationtests	52.3% <100.0%> (-9.4%)	⬇️
unittests	81.6% <66.6%> (-0.6%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...modules/dynamic_sidecar/scheduler/_core/_events.py	97.2% <ø> (+38.3%)	⬆️
...ice_webserver/director_v2_core_dynamic_services.py	69.3% <ø> (ø)
...simcore_service_webserver/projects/projects_api.py	75.6% <ø> (-5.5%)	⬇️
...vice_webserver/projects/projects_nodes_handlers.py	40.1% <ø> (-40.2%)	⬇️
...ice_director_v2/models/domains/dynamic_services.py	100.0% <100.0%> (ø)
...or_v2/models/schemas/dynamic_services/scheduler.py	99.3% <100.0%> (+2.0%)	⬆️
...v2/modules/dynamic_sidecar/docker_compose_specs.py	99.0% <100.0%> (+29.5%)	⬆️
...r/src/simcore_service_webserver/projects/_ports.py	32.9% <0.0%> (-61.0%)	⬇️
...vice_webserver/projects/projects_ports_handlers.py	59.6% <0.0%> (-34.5%)	⬇️
... and 151 more

[GitHK]

👍

Could you make sure that if from_service_inspect does not receive the product_name field encoded in the label, this still works. Just double check this.

[pcrespov]

Could you make sure that if from_service_inspect does not receive the product_name field encoded in the label, this still works. Just double check this.

@GitHK Can you please guide me on how to test this?

[mguidon]

Lgtm

[sanderegg]

all good. you have a missing @testit marker.

[codeclimate]

Code Climate has analyzed commit b415f9a and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication