Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Frontend: fix Shared with sorting #3845

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 6, 2023

What do these changes do?

  • Bugfix: do not override collaborator information
  • Refactor sorting by accessRights methods
  • Shorter NavBar: 60px -> 50px

Related issue/s

fixes ITISFoundation/osparc-issues#856

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Feb 6, 2023
@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Feb 6, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:馃悰bugfix labels Feb 6, 2023
@odeimaiz odeimaiz marked this pull request as ready for review February 7, 2023 12:50
@odeimaiz odeimaiz enabled auto-merge (squash) February 7, 2023 12:58
@codeclimate
Copy link

codeclimate bot commented Feb 7, 2023

Code Climate has analyzed commit 3f12a82 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias

@odeimaiz odeimaiz merged commit ca25948 into ITISFoundation:master Feb 7, 2023
@odeimaiz odeimaiz deleted the bugfix/services-in-study branch February 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServicesInStudyUpdate is not rendered/fails
4 participants