Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Cleaning up logs #3846

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Feb 7, 2023

What do these changes do?

Some log messages are not helpful. Refactoring logs to make them more useful.

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3846 (bb2aaf3) into master (cb08172) will decrease coverage by 14.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3846      +/-   ##
=========================================
- Coverage    85.7%   70.9%   -14.8%     
=========================================
  Files         618     383     -235     
  Lines       29944   19598   -10346     
  Branches      438     137     -301     
=========================================
- Hits        25664   13897   -11767     
- Misses       4149    5652    +1503     
+ Partials      131      49      -82     
Flag Coverage Δ
integrationtests 65.1% <66.6%> (-1.6%) ⬇️
unittests 85.8% <100.0%> (+3.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/dynamic_sidecar/scheduler/_core/_events_utils.py 94.5% <ø> (ø)
...ore_service_director_v2/utils/client_decorators.py 87.8% <100.0%> (+7.8%) ⬆️
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) ⬇️
...mcore_service_webserver/projects/projects_utils.py 21.9% <0.0%> (-65.4%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) ⬇️
... and 376 more

@GitHK GitHK self-assigned this Feb 7, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Feb 7, 2023
@GitHK GitHK added this to the Resistance Is Futile milestone Feb 7, 2023
@GitHK GitHK marked this pull request as ready for review February 7, 2023 09:38
@GitHK GitHK requested a review from mguidon February 7, 2023 09:38
@codeclimate
Copy link

codeclimate bot commented Feb 7, 2023

Code Climate has analyzed commit bb2aaf3 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@pcrespov pcrespov merged commit 1aa8bcf into ITISFoundation:master Feb 7, 2023
@GitHK GitHK deleted the pr-osparc-dv2-more-enhancements branch February 7, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants