Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds release tag, date and url in /config #3861

Merged
merged 9 commits into from
Feb 11, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 9, 2023

What do these changes do?

  • Adds new templates by @eofli @drniiken (until we can add all of them in database)
  • Adds to v0/config release information (if available). For instance:
{
 "data": {
   "invitation_required": false,
   "api_version": "0.15.0",
   "app_name": "simcore_service_webserver",
   "vcs_release_tag": "staging_ResistanceIsFutile12",
   "vcs_release_date": "2023-02-10T18:03:35.957601",
   "vcs_release_url": "https://github.com/ITISFoundation/osparc-simcore/releases/tag/staging_ResistanceIsFutile12"
 }
}

and also in /static-frontend-data.json

{
    "apiVersion": "0.15.0",
    "appName": "simcore_service_webserver",
    "vcsReleaseTag": "staging_ResistanceIsFutile12",
    "vcsReleaseDate": "2023-02-10T18:03:35.957601",
    "vcsReleaseUrl": "https://github.com/ITISFoundation/osparc-simcore/releases/tag/staging_ResistanceIsFutile12",
    # ...
    "stackName": "master-simcore",
    "displayName": "o\u00b2S\u00b2PARC",
}

How to test

cd services/web/server
make install-dev
pytest -vv test/unit/isolated

Checklist

  • Unit tests for the changes exist: test w/ and w/o SIMCORE_ environs
  • Runs in the swarm

@pcrespov pcrespov self-assigned this Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #3861 (6f29c36) into master (232de43) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3861   +/-   ##
======================================
  Coverage    85.1%   85.1%           
======================================
  Files         929     929           
  Lines       39823   39836   +13     
  Branches      837     837           
======================================
+ Hits        33905   33919   +14     
+ Misses       5697    5696    -1     
  Partials      221     221           
Flag Coverage Δ
integrationtests 66.8% <81.2%> (+<0.1%) ⬆️
unittests 82.2% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_webserver/application_settings.py 98.7% <100.0%> (+0.1%) ⬆️
...ver/src/simcore_service_webserver/rest_handlers.py 87.5% <100.0%> (+0.3%) ⬆️
...rary/src/servicelib/fastapi/requests_decorators.py 80.3% <0.0%> (-4.0%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 91.1% <0.0%> (-1.9%) ⬇️
...ore_service_director_v2/api/routes/computations.py 93.3% <0.0%> (-1.5%) ⬇️
.../director/src/simcore_service_director/producer.py 67.5% <0.0%> (-0.3%) ⬇️
...simcore_service_director_v2/modules/node_rights.py 99.0% <0.0%> (+0.9%) ⬆️
.../server/src/simcore_service_webserver/users_api.py 96.5% <0.0%> (+1.3%) ⬆️
...webserver/computation_comp_tasks_listening_task.py 85.1% <0.0%> (+3.1%) ⬆️
...simcore_service_webserver/director_v2_core_base.py 92.1% <0.0%> (+7.8%) ⬆️

@pcrespov pcrespov changed the title WIP: ✨ Adds release tag, date and url in /config ✨ Adds release tag, date and url in /config Feb 10, 2023
@pcrespov pcrespov marked this pull request as ready for review February 10, 2023 15:32
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Feb 10, 2023
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@codeclimate
Copy link

codeclimate bot commented Feb 11, 2023

Code Climate has analyzed commit 6f29c36 and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov enabled auto-merge (squash) February 11, 2023 18:21
@pcrespov pcrespov requested a review from eofli February 11, 2023 18:21
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants