🐛 Fix: GC error

[GitHK]

What do these changes do?

GC is not closing services as expected. Sidecars remain on nodes.

Fixes below issue:

[simcore_service_webserver.garbage_collector_task:collect_garbage_periodically(89)]  -  Stopped: There was an error during garbage collection, restarting...
Traceback (most recent call last):
  File "/home/scu/.venv/lib/python3.9/site-packages/simcore_service_webserver/garbage_collector_task.py", line 73, in collect_garbage_periodically
    await collect_garbage(app)
  File "/home/scu/.venv/lib/python3.9/site-packages/simcore_service_webserver/garbage_collector_core.py", line 89, in collect_garbage
    await remove_orphaned_services(registry, app)
  File "/home/scu/.venv/lib/python3.9/site-packages/simcore_service_webserver/garbage_collector_core.py", line 399, in remove_orphaned_services
    currently_opened_projects_node_ids[node_ids] = project_uuid
TypeError: unhashable type: 'set'

Related issue/s

How to test

Checklist

• Unit tests for the changes exist

[codecov]

Codecov Report

Merging #3868 (2813ab0) into master (35cce4f) will decrease coverage by 12.4%.
The diff coverage is 0.0%.

❗ Current head 2813ab0 differs from pull request most recent head 0738f76. Consider uploading reports for the commit 0738f76 to get more accurate results

@@            Coverage Diff            @@
##           master   #3868      +/-   ##
=========================================
- Coverage    83.1%   70.8%   -12.4%     
=========================================
  Files         929     235     -694     
  Lines       39836   12049   -27787     
  Branches      837       0     -837     
=========================================
- Hits        33142    8540   -24602     
+ Misses       6473    3509    -2964     
+ Partials      221       0     -221     

Flag	Coverage Δ
integrationtests	59.1% <0.0%> (+11.8%)	⬆️
unittests	66.3% <0.0%> (-16.0%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...imcore_service_webserver/garbage_collector_core.py	61.5% <0.0%> (+1.4%)	⬆️
...r/src/simcore_service_webserver/storage_schemas.py	0.0% <0.0%> (-100.0%)	⬇️
...service_webserver/projects/_project_models_rest.py	0.0% <0.0%> (-100.0%)	⬇️
...erver/src/simcore_service_webserver/rest_models.py	0.0% <0.0%> (-92.7%)	⬇️
...simcore_service_webserver/director/director_api.py	0.0% <0.0%> (-76.0%)	⬇️
...mcore_service_webserver/projects/projects_utils.py	21.9% <0.0%> (-65.4%)	⬇️
...src/simcore_service_webserver/activity/handlers.py	29.3% <0.0%> (-63.8%)	⬇️
...ce_webserver/studies_dispatcher/_studies_access.py	22.7% <0.0%> (-63.7%)	⬇️
...ver/src/simcore_service_webserver/catalog_units.py	24.0% <0.0%> (-61.2%)	⬇️
...r/src/simcore_service_webserver/projects/_ports.py	32.9% <0.0%> (-61.0%)	⬇️
... and 795 more

[mguidon]

LGTM

[sanderegg]

ok

[codeclimate]

Code Climate has analyzed commit 0738f76 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.2% Duplication