Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Frontend refactoring: Product functions #3872

Merged
merged 3 commits into from
Feb 13, 2023
Merged

♻️ Frontend refactoring: Product functions #3872

merged 3 commits into from
Feb 13, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 13, 2023 •
edited

What do these changes do?

  • Move product related logic to product.Utils
  • Improve study/template alias functions

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added this to the Resistance Is Futile milestone Feb 13, 2023
@odeimaiz odeimaiz self-assigned this Feb 13, 2023
@odeimaiz odeimaiz changed the title Alias function improved Frontend refactoring: Product functinos Feb 13, 2023
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:♻️refactor labels Feb 13, 2023
@odeimaiz odeimaiz changed the title Frontend refactoring: Product functinos ♻️ Frontend refactoring: Product functions Feb 13, 2023
mguidon
mguidon approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz marked this pull request as ready for review February 13, 2023 12:38
@odeimaiz odeimaiz enabled auto-merge (squash) February 13, 2023 12:39
@codeclimate
Copy link

codeclimate bot commented Feb 13, 2023

Code Climate has analyzed commit 4f14d38 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit f9e8f4d into ITISFoundation:master Feb 13, 2023
@sanderegg sanderegg mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@mguidon mguidon mguidon approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
Resistance Is Futile
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odeimaiz @pcrespov @mguidon