New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Maintenance upgrades tests and tools libraries #5346
⬆️ Maintenance upgrades tests and tools libraries #5346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5346 +/- ##
=========================================
+ Coverage 84.5% 87.4% +2.8%
=========================================
Files 10 1355 +1345
Lines 214 55945 +55731
Branches 25 1249 +1224
=========================================
+ Hits 181 48905 +48724
- Misses 23 6769 +6746
- Partials 10 271 +261
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ask me for a review when you mange to get the tests green again
60b4bf3
to
c3e416d
Compare
c3e416d
to
0e679d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this. I see we are getting behind on upgrades and need to address all this
bd9b563
to
1a388e7
Compare
1a388e7
to
ae00e20
Compare
ae00e20
to
c0f6b11
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Updates tests and tooling libraries before updating services. Since it was a while since last update, there are many changes.
Nonetheless, i call your attention on the major updates, namely:
Changes in code
setup.py
openapi_spec_validator.validate_spec
test_httpx_utils.py
that hard-coded versionpytest-lazyfixture
fails with pytest 8 (SEE Raise error withpytest==8.0.0
TvoroG/pytest-lazy-fixture#65): Modified the tests code to use parametrized fixtures instead of lazy-fixtures and removed the dependency.pytest-asyncio
(constraint to <0.22 due to Breaking change in 0.23.* pytest-dev/pytest-asyncio#706).pytest-aiohttp
where is not needed. NOTE: it is necessary untilaiohttp.pytest_plugin.loop
fixture retired!aiohttp<3.9
: Changes in 3.9 needs to be addressed on a separate PRIn detail
dask-sidecar🧪
dask-task-models-library🧪
environment-setup🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪
service-library🧪🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪
service-library🧪
service-library🧪
service-library🧪🧪
service-library🧪🧪
service-library🧪🧪
service-library🧪🧪
dask-sidecar🧪
dask-task-models-library🧪
director-v2🧪
environment-setup🧪
models-library🧪
postgres-database🧪
simcore-sdk🧪
swarm-deploy🧪
tests🧪
aws-library🧪
dask-task-models-library🧪
notifications-library🧪
osparc-gateway-server🧪
public-api🧪
service-library🧪
service-library🧪🧪
service-library🧪
service-library🧪🧪
service-library🧪🧪
dask-sidecar🧪
dask-task-models-library🧪
environment-setup🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪
Legend: