Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance upgrades tests and tools libraries #5346

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 19, 2024

What do these changes do?

Updates tests and tooling libraries before updating services. Since it was a while since last update, there are many changes.
Nonetheless, i call your attention on the major updates, namely:

Changes in code

  • ♻️ ruffed all old setup.py
  • ⬆️ api/test: removed deprecated openapi_spec_validator.validate_spec
  • 🎨 bad tests in test_httpx_utils.py that hard-coded version
  • 🗑️ pytest-lazyfixture fails with pytest 8 (SEE Raise error with pytest==8.0.0 TvoroG/pytest-lazy-fixture#65): Modified the tests code to use parametrized fixtures instead of lazy-fixtures and removed the dependency.
  • 🎨 uses pytest-asyncio (constraint to <0.22 due to Breaking change in 0.23.* pytest-dev/pytest-asyncio#706).
  • 🗑️ Removes pytest-aiohttp where is not needed. NOTE: it is necessary until aiohttp.pytest_plugin.loop fixture retired!
  • aiohttp<3.9: Changes in 3.9 needs to be addressed on a separate PR
  • ♻️ migration scripts in tests to get it to work after the update!

In detail

# name before after upgrade count packages
1 aiohttp 3.8.5, 3.8.6, 3.9.1 3.8.6 🔥 downgrade 7 aws-library🧪
dask-sidecar🧪
dask-task-models-library🧪
environment-setup🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪
2 arrow 1.3.0 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
3 dnspython 2.4.2 🗑️ removed 1 service-library🧪
4 email-validator 2.1.0.post1 🗑️ removed 1 service-library🧪
5 idna 3.6, 3.4 3.4 🔥 downgrade 4 dask-task-models-library🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪
6 jsonschema 4.19.2 🗑️ removed 2 environment-setup🧪
service-library🧪
7 jsonschema-specifications 2023.7.1 🗑️ removed 2 environment-setup🧪
service-library🧪
8 markdown-it-py 3.0.0 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
9 mdurl 0.1.2 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
10 orjson 3.9.10 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
11 pydantic 1.10.13 🗑️ removed 1 service-library🧪
12 pygments 2.16.1 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
13 pytest-aiohttp 1.0.5 🗑️ removed 10 aws-library🧪
dask-sidecar🧪
dask-task-models-library🧪
director-v2🧪
environment-setup🧪
models-library🧪
postgres-database🧪
simcore-sdk🧪
swarm-deploy🧪
tests🧪
14 pytest-asyncio 0.21.1, 0.23.5, 0.23.2 0.21.1 🔥 downgrade 6 autoscaling🧪
aws-library🧪
dask-task-models-library🧪
notifications-library🧪
osparc-gateway-server🧪
public-api🧪
15 pytest-lazy-fixture 0.6.3 🗑️ removed 1 simcore-sdk🧪
16 referencing 0.29.3 🗑️ removed 2 environment-setup🧪
service-library🧪
17 rich 13.6.0 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
18 rpds-py 0.10.6 🗑️ removed 2 environment-setup🧪
service-library🧪
19 typer 0.9.0 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
20 types-python-dateutil 2.8.19.14 🗑️ removed 3 environment-setup🧪
service-library🧪🧪
21 yarl 1.9.4, 1.9.2 1.9.2 🔥 downgrade 7 aws-library🧪
dask-sidecar🧪
dask-task-models-library🧪
environment-setup🧪
models-library🧪
osparc-gateway-server🧪
postgres-database🧪

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

@pcrespov pcrespov marked this pull request as ready for review February 19, 2024 10:04
@pcrespov pcrespov changed the title Maintenance/test tools upgrades Maintenance upgrades tests and tools libraries Feb 19, 2024
@pcrespov pcrespov self-assigned this Feb 19, 2024
@pcrespov pcrespov added dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work python labels Feb 19, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.4%. Comparing base (cafbf96) to head (3d70cf0).
Report is 42 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5346      +/-   ##
=========================================
+ Coverage    84.5%   87.4%    +2.8%     
=========================================
  Files          10    1355    +1345     
  Lines         214   55945   +55731     
  Branches       25    1249    +1224     
=========================================
+ Hits          181   48905   +48724     
- Misses         23    6769    +6746     
- Partials       10     271     +261     
Flag Coverage Δ
integrationtests 64.0% <ø> (?)
unittests 85.4% <ø> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1338 files with indirect coverage changes

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort

@pcrespov pcrespov enabled auto-merge (squash) February 19, 2024 13:33
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks!

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 💯

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ask me for a review when you mange to get the tests green again

@pcrespov pcrespov force-pushed the maintenance/test-tools-upgrades branch 3 times, most recently from 60b4bf3 to c3e416d Compare February 21, 2024 07:49
@pcrespov pcrespov changed the title Maintenance upgrades tests and tools libraries ⬆️ Maintenance upgrades tests and tools libraries Feb 21, 2024
@pcrespov pcrespov requested a review from GitHK February 21, 2024 09:31
@pcrespov pcrespov force-pushed the maintenance/test-tools-upgrades branch from c3e416d to 0e679d8 Compare February 21, 2024 12:09
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this. I see we are getting behind on upgrades and need to address all this

requirements/constraints.txt Show resolved Hide resolved
@pcrespov pcrespov force-pushed the maintenance/test-tools-upgrades branch 2 times, most recently from bd9b563 to 1a388e7 Compare February 23, 2024 10:56
@pcrespov pcrespov force-pushed the maintenance/test-tools-upgrades branch from 1a388e7 to ae00e20 Compare March 5, 2024 13:08
@pcrespov pcrespov force-pushed the maintenance/test-tools-upgrades branch from ae00e20 to c0f6b11 Compare March 21, 2024 18:57
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 9e9bbb2 into ITISFoundation:master Mar 22, 2024
56 checks passed
@pcrespov pcrespov deleted the maintenance/test-tools-upgrades branch March 22, 2024 19:04
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 3, 2024
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants