Move ITensorTDVP.jl MPS solver code into ITensorNetworks.jl
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good – if you and Lander find this to be the easiest then I'm all for it. I just didn't want Lander to have to re-create his PR here if that ended up being more work; but if it's less work then it is the way to go. |
|
Also fine to deprecate those older types or leave them out completely. We can always re-wrap them into the existing system later if we want to. Or else provide an "upgrade path" from using functions taking ITensors.MPS to ITensorNetworks.MPS. |
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 80.17% 80.96% +0.78%
==========================================
Files 29 45 +16
Lines 1226 1828 +602
==========================================
+ Hits 983 1480 +497
- Misses 243 348 +105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the code in the package ITensorTDVP.jl into this package, including tests and examples.
This is in preparation for @leburgel's PR ITensor/ITensorTDVP.jl#43, which extends those MPS solver functions to general tree tensor networks which are defined in this package. We agreed it makes the most sense to just move that PR here to keep
ITensorTDVP.jldependent on onlyITensors.MPS/ITensors.MPO.It also makes
KrylovKit.eigsolvean alias forITensorNetworks.dmrg(previouslyITensorTDVP.dmrg).@emstoudenmire we had discussed merging ITensor/ITensorTDVP.jl#43 into
ITensorTDVP.jlbut I spoke to Lander and we both agreed it makes more sense this way. I think also we can be more aggressive about deprecating old types in this package, likeITensors.AbstractObserver,ITensors.Sweeps,ITensors.AbstractMPSand subtypes, etc.