Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor keyword argument processing, remove applyexp #62

Merged
merged 16 commits into from Feb 15, 2024
Merged

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Feb 14, 2024

  • Fix some keyword argument forwarding issues caused by this refactor.

Fixes https://itensor.discourse.group/t/itensortdvp-has-issues-with-svd-when-using-new-gpu-backend/1477.

src/tdvp.jl Outdated Show resolved Hide resolved
src/tdvp.jl Outdated Show resolved Hide resolved
src/tdvp.jl Outdated Show resolved Hide resolved
src/tdvp_generic.jl Outdated Show resolved Hide resolved
src/tdvp_generic.jl Outdated Show resolved Hide resolved
@mtfishman mtfishman changed the title Refactor keyword arguments Refactor keyword argument processing Feb 14, 2024
src/tdvp_step.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (61f64f0) 86.50% compared to head (37a795c) 84.09%.

Files Patch % Lines
src/defaults.jl 76.47% 8 Missing ⚠️
src/tdvp_generic.jl 80.00% 3 Missing ⚠️
src/tdvporder.jl 25.00% 3 Missing ⚠️
src/tdvp.jl 85.71% 2 Missing ⚠️
src/tdvp_step.jl 71.42% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   86.50%   84.09%   -2.41%     
==========================================
  Files          17       17              
  Lines         600      522      -78     
==========================================
- Hits          519      439      -80     
- Misses         81       83       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title Refactor keyword argument processing Refactor keyword argument processing, remove applyexp Feb 15, 2024
@mtfishman
Copy link
Member Author

@emstoudenmire note that I've removed the applyexp backend to simplify this codebase.

@mtfishman mtfishman merged commit 449e3a4 into main Feb 15, 2024
8 of 9 checks passed
@mtfishman mtfishman deleted the kwarg_refactor branch February 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants