Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] [BUG] Fix bug in in-place contract #1158

Merged
merged 6 commits into from Jul 25, 2023

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Jul 22, 2023

Description

Typo in the contract code, it tried to create a tuple of size NB instead of NC which will fail if NC != NB

@kmp5VT kmp5VT requested a review from mtfishman July 22, 2023 14:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #1158 (38b5a57) into main (93447d0) will decrease coverage by 31.02%.
The diff coverage is n/a.

❗ Current head 38b5a57 differs from pull request most recent head 25ac3bb. Consider uploading reports for the commit 25ac3bb to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main    #1158       +/-   ##
===========================================
- Coverage   85.28%   54.26%   -31.02%     
===========================================
  Files          87       86        -1     
  Lines        8368     8314       -54     
===========================================
- Hits         7137     4512     -2625     
- Misses       1231     3802     +2571     

see 37 files with indirect coverage changes

@mtfishman mtfishman changed the title [NDTensors][Debug] Fix Typo NB should be NC [NDTensors] [BUG] Fix Typo NB should be NC Jul 25, 2023
@mtfishman mtfishman changed the title [NDTensors] [BUG] Fix Typo NB should be NC [NDTensors] [BUG] Fix bug in in-place contract Jul 25, 2023
@mtfishman mtfishman merged commit 163ba6e into ITensor:main Jul 25, 2023
8 checks passed
@kmp5VT kmp5VT deleted the kmp5/debug/fix_typo branch April 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants