Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Add checkflux debug check to factorize #1307

Merged
merged 2 commits into from Feb 2, 2024

Conversation

emstoudenmire
Copy link
Collaborator

Adds a call to checkflux at the beginning of factorize when debug checks are enabled.

Related to this forum discussion.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8d28b5) 84.04% compared to head (417d745) 53.87%.

❗ Current head 417d745 differs from pull request most recent head 61d7b0e. Consider uploading reports for the commit 61d7b0e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1307       +/-   ##
===========================================
- Coverage   84.04%   53.87%   -30.18%     
===========================================
  Files         100       99        -1     
  Lines        8539     8488       -51     
===========================================
- Hits         7177     4573     -2604     
- Misses       1362     3915     +2553     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emstoudenmire
Copy link
Collaborator Author

@mtfishman please let me know if you think this is worth adding a unit test for.

@mtfishman
Copy link
Member

Thanks! I think it would be good to add a simple unit test.

@mtfishman mtfishman changed the title Add checkflux debug check to factorize [ITensors] Add checkflux debug check to factorize Jan 25, 2024
@mtfishman
Copy link
Member

I'll just merge this, since checkflux is tested I don't think this needs a specialized test.

@mtfishman mtfishman merged commit 98b95a2 into main Feb 2, 2024
9 checks passed
@mtfishman mtfishman deleted the factorize_flux_debug_check branch February 2, 2024 17:10
kmp5VT pushed a commit to kmp5VT/ITensors.jl that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants