Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncombining combiner bug when combined Index is not first index #401

Merged
merged 1 commit into from
May 28, 2020

Conversation

mtfishman
Copy link
Member

This bumps the version of NDTensors, which includes a bug fix for a certain case of uncombining when the index to be uncombined is not the first index in the IndexSet.

@mtfishman
Copy link
Member Author

This fixes #395. Need to wait for the new NDTensors version to get registered for the tests to be able to run.

@github-actions
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmarks:
    • Target: 28 May 2020 - 18:36
    • Baseline: 28 May 2020 - 18:40
  • Package commits:
    • Target: 3a80f8
    • Baseline: 87bc19
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["contract", "matmul_100"] 0.94 (5%) ✅ 1.00 (1%)
["contract", "matmul_40"] 1.05 (5%) ❌ 1.00 (1%)
["contract", "matmul_60"] 0.94 (5%) ✅ 1.00 (1%)
["inplace", "axpy!"] 1.06 (5%) ❌ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      29988 s          0 s       6440 s      22956 s          0 s
       #2  2294 MHz      37586 s          0 s       4865 s      16188 s          0 s
       
  Memory: 6.764884948730469 GB (2961.921875 MB free)
  Uptime: 607.0 sec
  Load Avg:  1.90625  1.42041015625  0.7353515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      42749 s          0 s       7942 s      34368 s          0 s
       #2  2294 MHz      57793 s          0 s       8248 s      18236 s          0 s
       
  Memory: 6.764884948730469 GB (2950.28125 MB free)
  Uptime: 865.0 sec
  Load Avg:  1.822265625  1.5166015625  0.93798828125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 28 May 2020 - 18:36
  • Package commit: 3a80f8
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 7.538 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 82.901 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 6.367 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 14.600 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 31.400 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 44.801 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 30.654 s (5%) 2.774 s 39.61 GiB (1%) 3599649
["dmrg", "1d_S=1_heisenberg_qn"] 24.890 s (5%) 3.459 s 18.12 GiB (1%) 179109343
["inplace", "axpy!"] 17.100 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      29988 s          0 s       6440 s      22956 s          0 s
       #2  2294 MHz      37586 s          0 s       4865 s      16188 s          0 s
       
  Memory: 6.764884948730469 GB (2961.921875 MB free)
  Uptime: 607.0 sec
  Load Avg:  1.90625  1.42041015625  0.7353515625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 28 May 2020 - 18:40
  • Package commit: 87bc19
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["contract", "heff_2site"] 7.872 ms (5%) 19.42 MiB (1%) 378
["contract", "matmul_100"] 88.501 μs (5%) 81.69 KiB (1%) 51
["contract", "matmul_20"] 6.183 μs (5%) 6.73 KiB (1%) 50
["contract", "matmul_40"] 13.900 μs (5%) 16.11 KiB (1%) 50
["contract", "matmul_60"] 33.400 μs (5%) 31.69 KiB (1%) 51
["contract", "matmul_80"] 46.700 μs (5%) 53.56 KiB (1%) 51
["dmrg", "1d_S=1_heisenberg"] 30.672 s (5%) 2.727 s 39.61 GiB (1%) 3599234
["dmrg", "1d_S=1_heisenberg_qn"] 24.900 s (5%) 3.149 s 18.12 GiB (1%) 179109343
["inplace", "axpy!"] 16.200 μs (5%) 2.08 KiB (1%) 41

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["contract"]
  • ["dmrg"]
  • ["inplace"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.4 LTS
  uname: Linux 5.3.0-1022-azure #23~18.04.1-Ubuntu SMP Mon May 11 11:55:56 UTC 2020 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz      42749 s          0 s       7942 s      34368 s          0 s
       #2  2294 MHz      57793 s          0 s       8248 s      18236 s          0 s
       
  Memory: 6.764884948730469 GB (2950.28125 MB free)
  Uptime: 865.0 sec
  Load Avg:  1.822265625  1.5166015625  0.93798828125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               79
Model name:          Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:            1
CPU MHz:             2294.687
BogoMIPS:            4589.37
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            51200K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor :Intel
Architecture :Broadwell
Model Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 256, 51200) kbytes
64 byte cache line size
Address Size 48 bits virtual, 44 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@mtfishman mtfishman merged commit 373b2b8 into master May 28, 2020
@mtfishman mtfishman deleted the uncombine_bug branch May 28, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant