Fix missing return statement in QNVal constructor #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user was reporting a surprising issue with a code that did a replaceinds! on a QNITensor. Even though replaceinds! is smart enough to handle arrows automatically, there was an error. The issue stemmed from a mod-3 QN which was having negative values which shouldn't happen by design. The error was that the QNVal constructor should have had a
return
keyword on a certain line which was missing and causing silent errors in some cases. Fixes #430