Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OrderedList to be initialized with an existing NodeCache #1

Open
wants to merge 1 commit into
base: v11.0.0.rc7
Choose a base branch
from

Conversation

aploshay
Copy link

@aploshay aploshay commented Jan 26, 2019

The current code seems a bit odd in that:

  • node_cache only has accessor (read-only) ability, and only privately
  • it's set with a nil guard in the initializer, but with no way to provide a value

So it seems like there was meant to be some way to pass in an initial value, but this wasn't fully implemented? In any case, we need that ability in pumpkin, and this provides it.

This change has already been pushed to the v11.0.0.rc8 branch of our fork, so that pumpkin pull request pumpkin pull request #186 can make use of it. This PR exists to facilitate review and discussion.

Note that the code for current active-fedora still contains the same initialization pattern (nil guard, with no way to pass a value) for @node_cache. Even if we're violating intended use of OrderedList by using it in a nested fashion, I'm still scratching my head over this setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant