-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PW_SID:799800] [1/4] rtnl: Fixup rtnetlink includes #25
base: workflow
Are you sure you want to change the base?
Conversation
man 7 rtnetlink suggests the 4 includes listed should be used. Also, remove rtnetlink.h inclusion from rtnl.h and move it into the individual code files.
Some platforms lack definitions of new netlink features. Fix this by including a local copy of the most up to date netlink.h header. CC ell/netlink.lo ell/netlink.c: In function ‘l_netlink_set_debug’: ell/netlink.c:629:56: error: ‘NETLINK_EXT_ACK’ undeclared (first use in this function) if (setsockopt(l_io_get_fd(netlink->io), SOL_NETLINK, NETLINK_EXT_ACK, ^ ell/netlink.c:629:56: note: each undeclared identifier is reported only once for each function it appears in ell/netlink.c: In function ‘netlink_parse_ext_ack_error’: ell/netlink.c:649:29: error: ‘NLM_F_ACK_TLVS’ undeclared (first use in this function) if (!(nlmsg->nlmsg_flags & NLM_F_ACK_TLVS)) ^ ell/netlink.c:657:29: error: ‘NLM_F_CAPPED’ undeclared (first use in this function) if (!(nlmsg->nlmsg_flags & NLM_F_CAPPED)) ^ ell/netlink.c:677:8: error: ‘NLMSGERR_ATTR_MSG’ undeclared (first use in this function) case NLMSGERR_ATTR_MSG: ^ ell/netlink.c:681:8: error: ‘NLMSGERR_ATTR_OFFS’ undeclared (first use in this function) case NLMSGERR_ATTR_OFFS: ^
Some old platforms lack definitions of rtnl features we depend on. Fix this by including a local copy of the most up to date rtnetlink.h header. CC ell/rtnl.lo ell/rtnl.c: In function ‘_rtnl_route_change’: ell/rtnl.c:1408:35: error: ‘RTA_EXPIRES’ undeclared (first use in this function) rta_buf += rta_add_u32(rta_buf, RTA_EXPIRES, ^ ell/rtnl.c:1408:35: note: each undeclared identifier is reported only once for each function it appears in
Fetch PR GitLint Output:
Make Distcheck Output:
Build - Configure Make Check Output:
Make Check w/Valgrind Output:
Incremental Build with patches Output:
Autotest Runner Output:
Clang Build Output:
|
c28464c
to
fd645d0
Compare
78034a9
to
08f869b
Compare
c9a5099
to
b0dd515
Compare
10b6ee7
to
e812438
Compare
e812438
to
6387437
Compare
9eaed6a
to
10b055b
Compare
df18c83
to
3d6b335
Compare
3d6b335
to
bdee3ce
Compare
4773ac9
to
8745764
Compare
8745764
to
c91f7e5
Compare
c5e478c
to
5cfea4b
Compare
5cfea4b
to
2517286
Compare
8be0bc3
to
62cb485
Compare
62cb485
to
57c8d67
Compare
57c8d67
to
d078c9c
Compare
d078c9c
to
a96766e
Compare
70750ab
to
108b545
Compare
cf9aae3
to
d96cbc5
Compare
man 7 rtnetlink suggests the 4 includes listed should be used. Also,
remove rtnetlink.h inclusion from rtnl.h and move it into the individual
code files.
ell/netconfig.c | 4 ++++
ell/rtnl.c | 5 ++++-
ell/rtnl.h | 3 ++-
unit/test-rtnl.c | 4 ++++
4 files changed, 14 insertions(+), 2 deletions(-)