Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:799800] [1/4] rtnl: Fixup rtnetlink includes #25

Open
wants to merge 7 commits into
base: workflow
Choose a base branch
from

Conversation

IWDTestBot
Copy link
Owner

man 7 rtnetlink suggests the 4 includes listed should be used. Also,
remove rtnetlink.h inclusion from rtnl.h and move it into the individual
code files.

ell/netconfig.c | 4 ++++
ell/rtnl.c | 5 ++++-
ell/rtnl.h | 3 ++-
unit/test-rtnl.c | 4 ++++
4 files changed, 14 insertions(+), 2 deletions(-)

jprestwo and others added 7 commits November 8, 2023 02:30
man 7 rtnetlink suggests the 4 includes listed should be used.  Also,
remove rtnetlink.h inclusion from rtnl.h and move it into the individual
code files.
Some platforms lack definitions of new netlink features.  Fix this
by including a local copy of the most up to date netlink.h header.

  CC       ell/netlink.lo
ell/netlink.c: In function ‘l_netlink_set_debug’:
ell/netlink.c:629:56: error: ‘NETLINK_EXT_ACK’ undeclared (first use in this function)
  if (setsockopt(l_io_get_fd(netlink->io), SOL_NETLINK, NETLINK_EXT_ACK,
                                                        ^
ell/netlink.c:629:56: note: each undeclared identifier is reported only once for each function it appears in
ell/netlink.c: In function ‘netlink_parse_ext_ack_error’:
ell/netlink.c:649:29: error: ‘NLM_F_ACK_TLVS’ undeclared (first use in this function)
  if (!(nlmsg->nlmsg_flags & NLM_F_ACK_TLVS))
                             ^
ell/netlink.c:657:29: error: ‘NLM_F_CAPPED’ undeclared (first use in this function)
  if (!(nlmsg->nlmsg_flags & NLM_F_CAPPED))
                             ^
ell/netlink.c:677:8: error: ‘NLMSGERR_ATTR_MSG’ undeclared (first use in this function)
   case NLMSGERR_ATTR_MSG:
        ^
ell/netlink.c:681:8: error: ‘NLMSGERR_ATTR_OFFS’ undeclared (first use in this function)
   case NLMSGERR_ATTR_OFFS:
        ^
Some old platforms lack definitions of rtnl features we depend on.  Fix
this by including a local copy of the most up to date rtnetlink.h
header.

  CC       ell/rtnl.lo
ell/rtnl.c: In function ‘_rtnl_route_change’:
ell/rtnl.c:1408:35: error: ‘RTA_EXPIRES’ undeclared (first use in this function)
   rta_buf += rta_add_u32(rta_buf, RTA_EXPIRES,
                                   ^
ell/rtnl.c:1408:35: note: each undeclared identifier is reported only once for each function it appears in
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 0.00 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 16.88 seconds
Result: FAIL

Output:

../../src/main.c: In function ‘main’:
../../src/main.c:578:30: error: ‘NETLINK_ROUTE’ undeclared (first use in this function)
  578 |         rtnl = l_netlink_new(NETLINK_ROUTE);
      |                              ^~~~~~~~~~~~~
../../src/main.c:578:30: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [Makefile:2563: src/main.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1729: all] Error 2
make: *** [Makefile:3347: distcheck] Error 1

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 9.11 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 11.17 seconds
Result: FAIL

Output:

src/main.c: In function ‘main’:
src/main.c:578:30: error: ‘NETLINK_ROUTE’ undeclared (first use in this function)
  578 |         rtnl = l_netlink_new(NETLINK_ROUTE);
      |                              ^~~~~~~~~~~~~
src/main.c:578:30: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:2563: src/main.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1729: all] Error 2

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 0.00 seconds
Result: SKIP

Output:

testrunner was skipped

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 14.64 seconds
Result: FAIL

Output:

src/main.c:578:23: error: use of undeclared identifier 'NETLINK_ROUTE'
        rtnl = l_netlink_new(NETLINK_ROUTE);
                             ^
1 error generated.
make[1]: *** [Makefile:2563: src/main.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1729: all] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants