Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:665727] [1/2] handshake: add support to work around buggy OWE APs #122

Closed
wants to merge 5 commits into from

Conversation

IWDTestBot
Copy link
Owner

The early OWE implementation for hostapd always used SHA256 to calculate
the PTK, which violates the spec for group 20 and 21. This bug was in
there long enough for the bug to make it into products and now it must
be worked around here.

If the workaround flag is set, always use SHA256 to calculate the PTK.

src/handshake.c | 3 ++-
src/handshake.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)

This was using a lambda function as input which runs much too fast
for UML to advance the time. Change this to sleep for 100ms between
each check.

This fixes the random hang in testNetconfig.
The early OWE implementation for hostapd always used SHA256 to calculate
the PTK, which violates the spec for group 20 and 21. This bug was in
there long enough for the bug to make it into products and now it must
be worked around here.

If the workaround flag is set, always use SHA256 to calculate the PTK.
If the AP has rejected two 2/4 messages when using OWE assume its buggy
and re-dervive the PTK in a way that it (hopefully) expects.
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.69 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 66.78 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 15.73 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.06 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 138.14 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 193.71 seconds
Result: PASS

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.32 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 1.42 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 61.56 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 19.87 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 6.70 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 170.57 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 233.90 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 910.72 seconds
Result: PASS

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 168.82 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from b88066b to 715ebbd Compare August 11, 2022 21:00
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from cd80816 to 1081046 Compare August 23, 2022 17:01
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from bacae4c to bf67c52 Compare August 24, 2022 16:40
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 1702cf9 to d7d43ee Compare September 7, 2022 21:26
@IWDTestBot IWDTestBot force-pushed the workflow branch 2 times, most recently from 4dd04ad to dc48e01 Compare September 7, 2022 21:52
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from a7eb9f8 to 2cb0444 Compare September 13, 2022 14:22
@IWDTestBot IWDTestBot force-pushed the workflow branch 4 times, most recently from 166654c to fe49085 Compare September 14, 2022 21:47
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 07478da to 4cf117b Compare September 16, 2022 16:51
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 2b8ee3c to 030468e Compare September 29, 2022 18:11
@IWDTestBot IWDTestBot force-pushed the workflow branch 5 times, most recently from 31e670b to 6ed130b Compare September 30, 2022 23:28
@IWDTestBot IWDTestBot force-pushed the workflow branch 2 times, most recently from c080c99 to a655e16 Compare October 4, 2022 16:01
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 0920c1e to 46a676a Compare October 6, 2022 14:05
@IWDTestBot IWDTestBot force-pushed the workflow branch 4 times, most recently from a550095 to b0822d9 Compare October 6, 2022 17:40
@IWDTestBot IWDTestBot closed this Oct 6, 2022
@IWDTestBot IWDTestBot deleted the 665727 branch October 6, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants