Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:807496] Reassoc/FT roaming unification #276

Open
wants to merge 17 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:807496] Reassoc/FT roaming unification #276

wants to merge 17 commits into from

Conversation

IWDTestBot
Copy link
Owner

If tests end in an unknown state it is sometimes required that IWD
be stopped manually in order for future tests to run. Add a stop()
method so test tearDown() methods can explicitly stop IWD.

autotests/util/iwd.py | 4 ++++
1 file changed, 4 insertions(+)

denkenz and others added 17 commits December 1, 2023 16:37
@denkenz @IWDTestBot
pmksa: Add skeleton
97c2a3a
@denkenz @IWDTestBot
unit: Add basic pmksa test
e2929bb
@jprestwo @IWDTestBot
Workflow's for syncing with upstream, build, unit test, and test-runner
05e2523
@jprestwo @IWDTestBot
workflow: use newer commit for hostapd
998e7cd
@jprestwo @IWDTestBot
ci: remove cache/ from tar file list
a1a43f3 
This is taken care of by the individual cache items and
if none exist, tar fails.
@jprestwo @IWDTestBot
ci: use kernel 5.19
f18b985
@jprestwo @IWDTestBot
ci: use iwd-ci after renaming to remove -v2
dbf7db9
@jprestwo @IWDTestBot
ci: remove set-output use, now deprecated
6787d1d
@jprestwo @IWDTestBot
auto-t: add explicit stop() to IWD class
803825f 
If tests end in an unknown state it is sometimes required that IWD
be stopped manually in order for future tests to run. Add a stop()
method so test tearDown() methods can explicitly stop IWD.
@jprestwo @IWDTestBot
auto-t: add association timeout test
f843102 
This tests ensures IWD disconnects after receiving an association
timeout event. This exposes a current bug where IWD does not
transition to disconnected after an association timeout when
FT-roaming.
@jprestwo @IWDTestBot
auto-t: only call set_value for changed values in default()
507c00c 
The default() method was added for convenience but was extending the
test times significantly when the hostapd config was lengthy. This
was because it called set_value for every value regardless if it
had changed. Instead store the current configuration and in default()
only reset values that differ.
@jprestwo @IWDTestBot
ft: add FTE/RSNE building to ft_prepare_handshake
4297885 
In preparation to remove ft_associate build the FTE/RSNE in
ft_prepare_handshake and set into the handshake object directly.
@jprestwo @IWDTestBot
ft: add ft_handshake_setup
fdba484 
This will be called from station after FT-authentication has
finished. It sets up the handshake object to perform reassociation.

This is essentially a copy-paste of ft_associate without sending
the actual frame.
@jprestwo @IWDTestBot
netdev: add netdev_ft_reassociate
062f9de 
Essentially exposes (and renames) netdev_ft_tx_associate in order to
be called similarly to netdev_reassociate/netdev_connect where a
connect callback can be provided. This will fix the current bug where
if association times out during FT IWD will hang and never transition
to disconnected.

This also removes the calling of the FT_ROAMED event and instead just
calls the connect callback (since its now set). This unifies the
callback path for reassociation and FT roaming.
@jprestwo @IWDTestBot
station: use netdev_ft_reassociate
674f547 
Using this will provide netdev with a connect callback and unify the
roaming result notification between FT and reassociation. Both paths
will now end up in station_reassociate_cb.

Fixes: 30c6a10 ("netdev: Separate connect_failed and disconnected paths")
@jprestwo @IWDTestBot
ft: remove ft_associate and helpers
84959e1 
The reassociation is done through netdev directly, these are no
longer needed.
@jprestwo @IWDTestBot
netdev: station: remove NETDEV_EVENT_FT_ROAMED
6f07c3d 
The notification for roaming success/failure is now handled with
the connect callback.
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.09 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 54.09 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 12.37 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 2.79 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 94.48 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 417.92 seconds
Result: PASS

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.50 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 13.37 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 37.94 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.38 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.38 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 78.79 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 338.63 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1720.20 seconds
Result: PASS

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 84.17 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 935d6cc to 1efe833 Compare December 13, 2023 16:28
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from a6b078e to 1c88fa1 Compare December 20, 2023 02:00
@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from d7c5f62 to 2526ce4 Compare January 2, 2024 17:24
@github-actions github-actions bot force-pushed the workflow branch 9 times, most recently from 68c71d2 to 43f4327 Compare March 4, 2024 20:00
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 4170bb4 to c067bc7 Compare March 15, 2024 14:00
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from f10f2fc to c2be9ec Compare March 28, 2024 23:30
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from ebbbc93 to 089fa9a Compare April 16, 2024 13:02
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 2192e98 to 43a07cc Compare May 9, 2024 15:24
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 2c7b52e to 58d64d4 Compare May 14, 2024 15:45
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 68d5156 to 953fb5e Compare June 4, 2024 13:45
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from a123040 to 568d50f Compare June 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IWDTestBot @denkenz @jprestwo