Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:810180] [1/5] network: remove 'path' from settings_load_pt_ecc #284

Open
wants to merge 13 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:810180] [1/5] network: remove 'path' from settings_load_pt_ecc #284

wants to merge 13 commits into from

Conversation

IWDTestBot
Copy link
Owner

The path argument was used purely for debugging. It can be just as
informational printing just the SSID of the profile that failed to
parse the setting without requiring callers allocate a string to
call the function.

src/network.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

denkenz and others added 13 commits December 13, 2023 23:21
@denkenz @IWDTestBot
pmksa: Add skeleton
a4701ef
@denkenz @IWDTestBot
unit: Add basic pmksa test
131560a
@jprestwo @IWDTestBot
Workflow's for syncing with upstream, build, unit test, and test-runner
f6c4f63
@jprestwo @IWDTestBot
workflow: use newer commit for hostapd
7aa632c
@jprestwo @IWDTestBot
ci: remove cache/ from tar file list
34f9188 
This is taken care of by the individual cache items and
if none exist, tar fails.
@jprestwo @IWDTestBot
ci: use kernel 5.19
6253f68
@jprestwo @IWDTestBot
ci: use iwd-ci after renaming to remove -v2
d015b6d
@jprestwo @IWDTestBot
ci: remove set-output use, now deprecated
f5b90a9
@jprestwo @IWDTestBot
network: remove 'path' from settings_load_pt_ecc
600cb5f 
The path argument was used purely for debugging. It can be just as
informational printing just the SSID of the profile that failed to
parse the setting without requiring callers allocate a string to
call the function.
@jprestwo @IWDTestBot
knownnetworks: network: support updating known network settings
795b45b 
Currently if a known network is modified on disk the settings are not
reloaded by network. Only disconnecting/reconnecting to the network
would update the settings. This poses an issue to DPP since its
creating or updating a known network after configuration then trying
to connect. The connection itself works fine since the PSK/passphrase
is set to the network object directly, but any additional settings
are not updated.

To fix this add a new UPDATED known network event. This is then
handled from within network and all settings read from disk are
applied to the network object.
@jprestwo @IWDTestBot
dpp: fix extra settings not being used when connecting
3c76b10 
After DPP completes all settings are written and synced to disk as
well as credentials set into the network object itself. The way
network/knownnetworks worked at the time did not actually re-load
these settings before the connection attempt was made which means
that extra settings not set into the network object were not used,
i.e. Hidden/Sendhostname. The connection itself always succeeded
because the network object was given the credentials directly via
setters.

Now network and knownnetworks support updating on the directory
watch callback and ADDED/UPDATED known network events. Take advantage
of this and if the network object already exists after DPP (from a
prior scan) wait unil known networks adds/updates the network and
issue the connection after that.
@jprestwo @IWDTestBot
auto-t: add DPP tests to check extra settings are applied
17b2098 
In order to test that extra settings are applied prior to connecting
two tests were added for hidden networks as well as one testing if
there is already an existing profile after DPP.

The reason hidden networks were used was due to the requirement of
the "Hidden" settings in the profile. If this setting doesn't get
sync'ed to disk the connection will fail.
@jprestwo @IWDTestBot
auto-t: increase RAM when running with valgrind (UML)
3074701 
This was done for QEMU but not for UML. Running more than a few
tests with --valgrind will generally thrown an OOM error pretty
quick.
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.94 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 54.38 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 12.27 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 2.58 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 95.67 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 263.89 seconds
Result: PASS

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.35 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 3.95 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 38.34 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.31 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.06 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 74.81 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 212.89 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1760.98 seconds
Result: FAIL

Output:

testDPP

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 83.15 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from a6b078e to 1c88fa1 Compare December 20, 2023 02:00
@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from d7c5f62 to 2526ce4 Compare January 2, 2024 17:24
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from c08a6fa to 1106532 Compare January 10, 2024 03:30
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 66ab708 to 4f2c8df Compare January 30, 2024 03:20
@github-actions github-actions bot force-pushed the workflow branch 10 times, most recently from a93a17f to 68c71d2 Compare March 4, 2024 07:59
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 4170bb4 to c067bc7 Compare March 15, 2024 14:00
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from f10f2fc to c2be9ec Compare March 28, 2024 23:30
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from ebbbc93 to 089fa9a Compare April 16, 2024 13:02
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 2192e98 to 43a07cc Compare May 9, 2024 15:24
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 2c7b52e to 58d64d4 Compare May 14, 2024 15:45
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 68d5156 to 953fb5e Compare June 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IWDTestBot @denkenz @jprestwo