Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:811802] Reduce and optimize quick/roam scan frequencies #289

Open
wants to merge 15 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:811802] Reduce and optimize quick/roam scan frequencies #289

wants to merge 15 commits into from

Conversation

IWDTestBot
Copy link
Owner

Rename to known_network_add_seen_frequency. This prepares to
differentiate between tracking frequencies based on a BSS being
seen versus being connected to. When a BSS has been connected to
that frequency should be preferred when roaming/quick scanning.

src/knownnetworks.c | 3 ++-
src/knownnetworks.h | 3 ++-
src/network.c | 6 +++---
3 files changed, 7 insertions(+), 5 deletions(-)

denkenz and others added 15 commits December 20, 2023 02:00
@denkenz @IWDTestBot
pmksa: Add skeleton
9420586
@denkenz @IWDTestBot
unit: Add basic pmksa test
8f704d0
@jprestwo @IWDTestBot
Workflow's for syncing with upstream, build, unit test, and test-runner
a6a21c6
@jprestwo @IWDTestBot
workflow: use newer commit for hostapd
143ab30
@jprestwo @IWDTestBot
ci: remove cache/ from tar file list
0fdd8fe 
This is taken care of by the individual cache items and
if none exist, tar fails.
@jprestwo @IWDTestBot
ci: use kernel 5.19
40ac070
@jprestwo @IWDTestBot
ci: use iwd-ci after renaming to remove -v2
dab4bb4
@jprestwo @IWDTestBot
ci: remove set-output use, now deprecated
1c88fa1
@jprestwo @IWDTestBot
known_network: rename known_network_add_frequency
65d7512 
Rename to known_network_add_seen_frequency. This prepares to
differentiate between tracking frequencies based on a BSS being
seen versus being connected to. When a BSS has been connected to
that frequency should be preferred when roaming/quick scanning.
@jprestwo @IWDTestBot
knownnetworks: add known_network_add_connected_frequency
1c2801b 
This should be called when BSS is connected/roamed to which will
insert the frequency ahead of entries which were only seen in scan
results.

Providing this and the 'seen' variant sets up the frequency list
into two adjacent sections:
  [Most recently used]...[Most recently seen]

Doing this will allow scanning to be more optimized and limit the
number of frequencies while prefering BSS's that have been connected
to prior.

Note that this list format is not synced to the file system.
Frequencies will be synced in the order of this list but not
containing the 'connected' bit. When IWD restarts this information
will be lost, but the list is still sorted on disk in a better state
than it was prior.
@jprestwo @IWDTestBot
network: call network_connected with BSS
3986db8 
This will allow the BSS frequency to be inserted at the head of the
known frequency list, allowing future scans to prefer that frequency.
@jprestwo @IWDTestBot
network: add network_roamed
57a3720 
Allows known frequencies to include the roam BSS frequency and
sync.
@jprestwo @IWDTestBot
station: use network_roamed
4c70796
@jprestwo @IWDTestBot
auto-t: update known frequency test to check order
042ebe6 
Known frequencies are stored in order of most recently used, so
add some logic to the test to exercise the reordering of frequencies
as connections are made.
@jprestwo @IWDTestBot
knownnetworks: limit 5 recent frequencies per network
6baadff 
Since this is meant to be used for quick/roam scans we should be
putting a cap on the frequencies scanned. For large networks with
many BSS's this could end up scanning quite a few frequencies which
isn't very 'quick' as it should be.

Since the known frequency list is now sorted in most recently used
order we can grab the first 5 frequencies per network and be
somewhat confident that this will result in a BSS to connect to.
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.04 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 55.94 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 12.43 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 2.62 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 97.06 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 342.92 seconds
Result: PASS

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.31 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 6.25 seconds
Result: FAIL

Output:

[6/7] auto-t: update known frequency test to check order
13: B1 Line exceeds max length (83>80): " rename autotests/testKnownNetworks/{ssidCCMP-2G.conf => ssidCCMP-2G-1.conf} (100%)"

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 37.87 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.49 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.17 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 79.53 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 276.45 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1743.23 seconds
Result: PASS

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 82.94 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from d7c5f62 to 2526ce4 Compare January 2, 2024 17:24
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from c08a6fa to 1106532 Compare January 10, 2024 03:30
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 4f2c8df to 263e09e Compare January 30, 2024 20:00
@github-actions github-actions bot force-pushed the workflow branch 9 times, most recently from 9eef0d5 to d3b4175 Compare February 28, 2024 18:01
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 68c71d2 to 43f4327 Compare March 4, 2024 20:00
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 4170bb4 to c067bc7 Compare March 15, 2024 14:00
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from f10f2fc to c2be9ec Compare March 28, 2024 23:30
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from ebbbc93 to 089fa9a Compare April 16, 2024 13:02
@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 2192e98 to 43a07cc Compare May 9, 2024 15:24
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from 2c7b52e to 58d64d4 Compare May 14, 2024 15:45
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from f7c5ee3 to 38fe7c3 Compare May 31, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IWDTestBot @denkenz @jprestwo