-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PW_SID:814719] build: make missing rst2man non-fatal #299
base: workflow
Are you sure you want to change the base?
Conversation
This is taken care of by the individual cache items and if none exist, tar fails.
The configure.ac script does not fail to configure if rst2man is missing but instead sets RUN_RST2MAN depending on if its available, i.e. makes it an optional requirement. But then in Makefile.am if RUN_RST2MAN is not set it fails fatally and will not continue with the build. Instead remove the false return so the build can continue. Another option would be to put a hard requirement on rst2man and not allow configure to proceed, but based on the existing logic it did not seem like this was the original intent.
Fetch PR Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches |
Fetch PR GitLint Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches Autotest Runner Clang Build |
c08a6fa
to
1106532
Compare
263e09e
to
a7e34e0
Compare
cf3bcb6
to
46b3556
Compare
9eef0d5
to
d3b4175
Compare
68c71d2
to
43f4327
Compare
4170bb4
to
c067bc7
Compare
f10f2fc
to
c2be9ec
Compare
ebbbc93
to
089fa9a
Compare
2192e98
to
43a07cc
Compare
2c7b52e
to
58d64d4
Compare
68d5156
to
953fb5e
Compare
The configure.ac script does not fail to configure if rst2man is missing
but instead sets RUN_RST2MAN depending on if its available, i.e. makes
it an optional requirement. But then in Makefile.am if RUN_RST2MAN is
not set it fails fatally and will not continue with the build.
Instead remove the false return so the build can continue. Another
option would be to put a hard requirement on rst2man and not allow
configure to proceed, but based on the existing logic it did not seem
like this was the original intent.
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)