fix(ocpi-2.2.1): Add Content-Type header on requests (if needed), on all responses & fixed headers case sensitivity #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, & on all responses - HttpUtils - OcpiResponseBody
lilgallon
force-pushed
the
fix/add-missing-headers-and-fix-post-credentials-response
branch
from
b523bcc
to
e32977a
Compare
It fixes debug headers not being sent in response if partner sends them in lowercase
lilgallon
force-pushed
the
fix/add-missing-headers-and-fix-post-credentials-response
branch
from
e32977a
to
d2728dc
Compare
lilgallon
changed the title
xhanin
reviewed
Oct 27, 2023
ocpi-toolkit-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/common/HttpUtils.kt
Outdated
Show resolved
Hide resolved
|
I will also add an option to specify explicitely the It can be useful if the users have a traceId in the coroutine context and want to use it |
…ransportClient It is useful to give the user the control on the generated debug headers.
|
It is now possible to define how X-Request-ID and X-Correlation-ID are generated. Two methods were added to TransportClient interface. By default, the behaviour stays the same, it generates a random UUID. I also greatly improved Credentials tests by checking every request / response done during the process. This mecanisme can be reused in integration tests for anything else. |
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
xhanin
approved these changes
Nov 1, 2023
ocpi-toolkit-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/common/HttpUtils.kt
Show resolved
Hide resolved
...olkit-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/modules/credentials/CredentialsClient.kt
Show resolved
Hide resolved
This was referenced Nov 2, 2023
lilgallon
deleted the
fix/add-missing-headers-and-fix-post-credentials-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change notes
Only for ocpi 2.2.1
Content-Type: application/jsonheader is now added on requests if the body is not nullContent-Type: application/jsonheader is now added on all responsesX-Request-IDandX-Correlation-IDare properly propagated in responses even if the case does not match. Note:Authorizationheader was working because it also acceptedauthorizationX-Request-IDandX-Correlation-IDare generated. You have to override methods in yourTransportClientimplementation. By default, the behaviour stays the same, it generates a randomUUID.Migration guide
If you manually added Content-Type header & normalized headers in your Transport implementation, you can remove it.
Otherwise, you do not need to update anything. All the changes are included in the lib.
Notes
For versions 2.1.1 and 2.1.1 Gireve, two issues have been open: